Adding session affinity support through loadbalancer distribution type

[elweb9858]

Adding session affinity support through loadbalancer distribution type

[jterry75]

@nagiesek - PTAL

[jterry75]

@elweb9858 - Can you rebase squash these and we can take it?

[erfrimod]

Looks good.

[ksubrmnn]

lgtm

[elweb9858]

@jterry75 can you make a new release of hcsshim with this change?

[jterry75]

We dont typically do that. Why cant you vendor the commit you need?

[ksubrmnn]

I imagine the Kubernetes work won’t be completed before code freeze on the 17th anyway. So we do have some time for this.

We get a lot of pushback when we try to vendor in hcsshim without a release.

There have been a few changes in the hcn code, and there hasn’t been a release since early February.

Can we get a timeline for the next release?

[jterry75]

We don't make (and have never made) tagged releases for anything but Docker and we cant specifically tag just the hcn package. @PatrickLang - I thought we decided Kubernetes was ok with this since we are a vendor only release and not a binary?

[ksubrmnn]

To clarify, we don’t expect hcn to be versioned. I understand it’s under the umbrella of hcs releases. Patrick will probably have all the context here, but I have personally seen pushback without a release. Though I’m sure we can still do it

[elweb9858]

@jterry75 I'm trying to get this change vendored into kubernetes, but hcsshim's dependency on containerd v1.3.0 breaks other things in kubernetes, namely github.com/google/cadvisor/container/containerd, which depends on containerd v1.0.2. Any idea how I can work around this?

[PatrickLang]

@elweb9858 - I'd ask in the Kubernetes slack (invite @ slack.k8s.io), channel #k8s-code-organization . There are discussions around moving to modules and impacts on vendoring there https://kubernetes.slack.com/archives/CHGFYJVAN/p1573237770111000