Updating containerd version #2367
Conversation
…nerd/containerd/pkg/dialer
|
Hi @eweber9858. Thanks for your PR. I'm waiting for a google member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@dashpole PTAL |
|
/ok-to-test |
|
cc @Random-Liu |
|
@eweber9858: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
You will need to rebase on top of #2370 to fix the test. |
|
This should no longer be needed. The containerd version was updated past this point in #2372 |
In order to vendor in this PR (microsoft/hcsshim#730) to kubernetes, the containerd/containerd dependency must also be upgraded to a newer version (github.com/containerd/containerd v1.3.0-beta.2.0.20190828155532-0293cbd26c69). This newer version is incompatible with google/cadvisor because of this commit, where the github.com/containerd/containerd/dialer package was moved to github.com/containerd/containerd/pkg/dialer. This change in path is disruptive to google/cadvisor because the dialer package is imported in container/containerd/client.go.
This PR bumps the containerd version to v1.2.0, which is one of the earliest releases of containerd with the needed change (another option is to bump to the latest version, v1.3.2)