Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[267] Add cross-workspace support to the Terra storage provider. #272

Merged
merged 9 commits into from
Jul 1, 2023

Conversation

giventocode
Copy link
Contributor

@giventocode giventocode commented Jun 30, 2023

Closes: #267

This PR includes:

  • TerraStorageAccessProvider generates SAS tokens from any URL Azure storage container managed by Terra provided the user has access to it.
  • The implementation in based on the following assumptions:
    • The storage container name contains the workspace id.
    • The storage account is a valid LZ storage account that follows its naming convention.
  • Removed unnecessary logic to handle local paths as well as a "known" folders as this logic does not apply to Terra
  • Added basic integration test infrastructure for Terra.
    • These integration tests are disabled.

@giventocode giventocode requested a review from BMurri June 30, 2023 22:15
@giventocode giventocode merged commit 243a4aa into main Jul 1, 2023
@giventocode giventocode deleted the ja-wkspace-clonning branch July 1, 2023 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support cross-workspace containers when TES runs on Terra
2 participants