Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix logistic regression error when passing "--link logistic" #644

Merged
merged 3 commits into from
Aug 9, 2019

Conversation

eisber
Copy link
Collaborator

@eisber eisber commented Aug 9, 2019

fixes #642
updates to latest VW (required for link logistic fix)
fixes logistic regression unit test

@eisber
Copy link
Collaborator Author

eisber commented Aug 9, 2019

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@codecov
Copy link

codecov bot commented Aug 9, 2019

Codecov Report

Merging #644 into master will decrease coverage by 21.58%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #644       +/-   ##
===========================================
- Coverage   76.77%   55.18%   -21.59%     
===========================================
  Files         224      171       -53     
  Lines        8963     7805     -1158     
  Branches      488      489        +1     
===========================================
- Hits         6881     4307     -2574     
- Misses       2082     3498     +1416
Flag Coverage Δ
#python 100% <ø> (+52.15%) ⬆️
#scala 55.18% <100%> (-25.89%) ⬇️
Impacted Files Coverage Δ
...a/com/microsoft/ml/spark/vw/VowpalWabbitBase.scala 85.81% <100%> (+0.19%) ⬆️
...microsoft/ml/spark/vw/VowpalWabbitClassifier.scala 86.36% <100%> (+4.54%) ⬆️
.../com/microsoft/ml/spark/lightgbm/TrainParams.scala 0% <0%> (-100%) ⬇️
...cala/com/microsoft/ml/spark/io/binary/Binary.scala 0% <0%> (-100%) ⬇️
.../microsoft/ml/spark/lightgbm/LightGBMBooster.scala 0% <0%> (-98.77%) ⬇️
...ql/execution/streaming/continuous/HTTPSinkV2.scala 0% <0%> (-96.56%) ⬇️
.../microsoft/ml/spark/lightgbm/LightGBMDataset.scala 0% <0%> (-96.16%) ⬇️
...om/microsoft/ml/spark/lightgbm/LightGBMUtils.scala 0% <0%> (-95.3%) ⬇️
.../execution/streaming/continuous/HTTPSourceV2.scala 0% <0%> (-92.6%) ⬇️
...a/com/microsoft/ml/spark/lightgbm/TrainUtils.scala 0% <0%> (-89.96%) ⬇️
... and 106 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b6a4f93...6cb4c94. Read the comment docs.

@eisber
Copy link
Collaborator Author

eisber commented Aug 9, 2019

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@eisber eisber changed the title Fix logistic regression probs when passing link logistic & duplicate params Fix: logistic regression probs when passing link logistic & duplicate params Aug 9, 2019
@eisber eisber changed the title Fix: logistic regression probs when passing link logistic & duplicate params Fix(ogistic regression probs): lwhen passing link logistic & duplicate params Aug 9, 2019
@eisber eisber changed the title Fix(ogistic regression probs): lwhen passing link logistic & duplicate params Fix(logistic regression probs): when passing "--link logistic" Aug 9, 2019
@mhamilton723 mhamilton723 changed the title Fix(logistic regression probs): when passing "--link logistic" fix: Fix logistic regression error when passing "--link logistic" Aug 9, 2019
@mhamilton723 mhamilton723 merged commit eeb7eba into microsoft:master Aug 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

VW setting parameters is confusing
2 participants