Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VW setting parameters is confusing #642

Closed
loomlike opened this issue Aug 7, 2019 · 1 comment · Fixed by #644
Closed

VW setting parameters is confusing #642

loomlike opened this issue Aug 7, 2019 · 1 comment · Fixed by #644
Assignees

Comments

@loomlike
Copy link
Contributor

loomlike commented Aug 7, 2019

I'm trying to use VW (which is really nice to see from mmlspark!) and setting parameters is somewhat confusing, as some arguments can be set as a builder pattern (setNumPasses and setNumBits) while some should set via setArgs.

It would be nice to be able to use setArgs for all parameters. Then, if I set the same parameter via both the builder and setArgs, I will expect one (maybe builder pattern because I explicitly called) override the other.

@welcome
Copy link

welcome bot commented Aug 7, 2019

👋 Thanks for opening your first issue here! If you're reporting a 🐞 bug, please make sure you include steps to reproduce it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants