Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] Skips adding a $count path if a similar count() function path exists #351

Merged
merged 13 commits into from
Feb 27, 2023
Merged

[Fix] Skips adding a $count path if a similar count() function path exists #351

merged 13 commits into from
Feb 27, 2023

Conversation

irvinesunday
Copy link
Contributor

Fixes #347

@irvinesunday irvinesunday self-assigned this Feb 27, 2023
@irvinesunday irvinesunday marked this pull request as draft February 27, 2023 17:20
baywet
baywet requested changes Feb 27, 2023
View reviewed changes
Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix here, appreciated. A couple of comments + a unit test and we should be good to go on this one.

irvinesunday and others added 3 commits February 27, 2023 20:58
@irvinesunday
Update test
3c7552a
@irvinesunday @baywet
Update src/Microsoft.OpenApi.OData.Reader/Edm/ODataPathProvider.cs
90ff41b 
Co-authored-by: Vincent Biret <vibiret@microsoft.com>
@irvinesunday @baywet
Update src/Microsoft.OpenApi.OData.Reader/Edm/ODataPathProvider.cs
0b6db9b 
Co-authored-by: Vincent Biret <vibiret@microsoft.com>
baywet
baywet approved these changes Feb 27, 2023
View reviewed changes
Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking in the changes!

baywet
baywet previously approved these changes Feb 27, 2023
View reviewed changes
@irvinesunday irvinesunday marked this pull request as ready for review February 27, 2023 18:58
@baywet
Copy link
Member

baywet commented Feb 27, 2023

@irvinesunday a couple of unit tests are failing, can you look into that please?

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

90.7% 90.7% Coverage
0.0% 0.0% Duplication

@irvinesunday irvinesunday merged commit 07f0d2e into master Feb 27, 2023
@irvinesunday irvinesunday deleted the fix/is/count-path-segments-conditional branch February 27, 2023 21:56
@baywet baywet mentioned this pull request Feb 27, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baywet baywet baywet approved these changes

@xuzhg xuzhg Awaiting requested review from xuzhg

@darrelmiller darrelmiller Awaiting requested review from darrelmiller

@peombwa peombwa Awaiting requested review from peombwa

@zengin zengin Awaiting requested review from zengin

@millicentachieng millicentachieng Awaiting requested review from millicentachieng

Assignees

@irvinesunday irvinesunday

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

$count path segment should not be added if a count function is present
2 participants
@irvinesunday @baywet