Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Strips namespace prefix from operation segments and aliases type cast segments #350

Merged
merged 18 commits into from
Feb 28, 2023
Merged

Strips namespace prefix from operation segments and aliases type cast segments #350

merged 18 commits into from
Feb 28, 2023

Conversation

irvinesunday
Copy link
Contributor

Fixes #348

This PR:

  • Removes the base namespace identifier from operation segments.
  • To remove the namespace to make unqualified calls, set the convert setting EnableUnqualifiedCall=true and set the BaseNamespace value to the base namespace value that needs to be stripped.

@irvinesunday irvinesunday requested a review from xuzhg as a code owner February 24, 2023 13:40
@irvinesunday irvinesunday self-assigned this Feb 24, 2023
@irvinesunday irvinesunday marked this pull request as draft February 24, 2023 13:40
baywet
baywet previously approved these changes Feb 27, 2023
View reviewed changes
@irvinesunday irvinesunday marked this pull request as ready for review February 27, 2023 21:50
baywet
baywet previously approved these changes Feb 27, 2023
View reviewed changes
@baywet
Copy link
Member

baywet commented Feb 27, 2023

@irvinesunday since #351 got merged, this is conflicting FYI

@irvinesunday
Copy link
Contributor Author

@irvinesunday since #351 got merged, this is conflicting FYI

Yes. Resolving the conflicts.

andrueastman
andrueastman previously approved these changes Feb 28, 2023
View reviewed changes
@andrueastman andrueastman self-requested a review February 28, 2023 07:28
baywet
baywet previously approved these changes Feb 28, 2023
View reviewed changes
@baywet baywet disabled auto-merge February 28, 2023 12:30
@irvinesunday irvinesunday changed the title Removes base namespace identifier from operation segments Strips namespace prefix from operation segments and aliases type cast segments Feb 28, 2023
baywet
baywet previously approved these changes Feb 28, 2023
View reviewed changes
@andrueastman andrueastman force-pushed the feature/is/remove-namespace branch from f53fc7a to d8b34af Compare February 28, 2023 12:46
@baywet baywet enabled auto-merge February 28, 2023 12:47
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

95.2% 95.2% Coverage
0.0% 0.0% Duplication

@baywet baywet merged commit 0775a63 into master Feb 28, 2023
@baywet baywet deleted the feature/is/remove-namespace branch February 28, 2023 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baywet baywet baywet approved these changes

@xuzhg xuzhg Awaiting requested review from xuzhg

@darrelmiller darrelmiller Awaiting requested review from darrelmiller

@peombwa peombwa Awaiting requested review from peombwa

@zengin zengin Awaiting requested review from zengin

@millicentachieng millicentachieng Awaiting requested review from millicentachieng

@andrueastman andrueastman Awaiting requested review from andrueastman

Assignees

@irvinesunday irvinesunday

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Adds a setting to strip namespace prefix from path for OData methods
3 participants
@irvinesunday @baywet @andrueastman