Add support for recursive dictionary templating to more places #614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bpkroth
commented
Nov 29, 2023
This was referenced Nov 29, 2023
bpkroth
commented
Nov 29, 2023
bpkroth
commented
Nov 29, 2023
bpkroth
commented
Nov 29, 2023
motus
approved these changes
Nov 29, 2023
mlos_bench/mlos_bench/services/remote/azure/azure_vm_services.py
Outdated
Show resolved
Hide resolved
motus
approved these changes
Nov 29, 2023
bpkroth
added a commit
that referenced
this pull request
Dec 1, 2023
…s platforms (#618) Fixes a bug introduced in #614 for Windows tests. On Windows, ```python os.environ["string"] = "str" ``` internally gets replaced as ```python os.environ["STRING"] ``` The workaround is to use `nt.environ` on Windows instead. This change introduces an abstraction to use a new simple drop in replacement library everywhere we need to handle environment variables.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes extracted from #606
This expands support for doing secondary
$varstring template expansion to two additional places beyondglobal_config:const_argsdeploymentTemplateParametersinAzureVmService(and soonAzureNetworkService)Expands a few test cases to check for this and relies on one prior existing one to still pass (the
launch_parse_argstests which already checked for this behavior inglobal_configexpansion).