Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move deploymentName to Environment args instead of Service config #610

Closed
bpkroth opened this issue Nov 22, 2023 · 2 comments · Fixed by #616
Closed

Move deploymentName to Environment args instead of Service config #610

bpkroth opened this issue Nov 22, 2023 · 2 comments · Fixed by #616
Assignees
@bpkroth

Comments

@bpkroth
Copy link
Contributor

bpkroth commented Nov 22, 2023 •
edited
Loading

For multiple deployments to be possible by the same Service (e.g., separate client and server VM deployments), we need to be able to pass a different deploymentName to each.

To do this, we should move deploymentName into an Environment arg rather than part of the Service config.

Additionally, deploymentName and other deploymentParameters should be templateable via globals (e.g., "deploymentName": "$experiment_id-server")
@bpkroth bpkroth self-assigned this Nov 22, 2023
@bpkroth
Copy link
Contributor Author

bpkroth commented Nov 22, 2023

Easiest to do this after #606 I think

@bpkroth bpkroth mentioned this issue Nov 22, 2023
Merged
7 tasks
@bpkroth
Copy link
Contributor Author

bpkroth commented Nov 29, 2023

#614 also should help with this since then we can make the vmName part of the deploymentName.
Related will be adding support for multiple worker instances (e.g., for parallel execution - #380)

bpkroth added a commit to bpkroth/MLOS that referenced this issue Nov 30, 2023
@bpkroth
Move deploymentName from the Service config to the Environment config
ae45996 
Needed so that we can support multiple Environment deployments under the same Service.

Closes microsoft#610
@bpkroth bpkroth mentioned this issue Nov 30, 2023
Merged
bpkroth added a commit that referenced this issue Dec 1, 2023
@bpkroth
Move deploymentName from the Service config to the Environment config (…
3824f0c 
…#616)

Needed so that we can support multiple Environment deployments under the
same Service.

Closes #610
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bpkroth bpkroth

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Move deploymentName from the Service config to the Environment config bpkroth/MLOS
1 participant
@bpkroth