ci: Add integration and deployment pipelines #26
Conversation
| runs-on: ubuntu-latest | ||
| strategy: | ||
| matrix: | ||
| python-version: ["3.8", "3.9"] #, "3.10", "3.11", "3.12"] |
There was a problem hiding this comment.
Are there issues with 3.10 and later or why are those disabled here?
There was a problem hiding this comment.
I quote the PR description:
Our current pytest version doesn't support python > 3.9, which is why tests are not run there yet. I can file another PR after this is merged
.github/workflows/ci.yaml
Outdated
| - name: Install | ||
| run: pip install .[tests] | ||
| - name: Run tests | ||
| run: pytest --junitxml=junit/test-results.xml --cov=com --cov-report=xml --cov-report=html |
There was a problem hiding this comment.
Is it useful to generate the coverage report if that is not used?
What about uploading the report HTML and maybe XML as a build artifact? That way it could be inspected at least.
There was a problem hiding this comment.
No its not. I just copied the command I ran locally, didn't figured out yet how to store the artifacts. I am going to dig into this now, thank you for the reminder!
There was a problem hiding this comment.
I think I configured it to post comments to the PRs, however this is hard to test :/
There was a problem hiding this comment.
I created a test case in my own repo by merging this and filing a new PR: georgkrause#2
There was a problem hiding this comment.
The display is a little bit confusing because tests are part of the package and the display doesn't add categories for the different python versions.
There was a problem hiding this comment.
I see. But I think that would be fine that's something that can be improved, and if something shows up there one can always start looking into the actual artifacts as well.
I assume the reason why the actions haven't been run here is because they need someone with write access (I don't) to trigger the run, right? Or maybe actions have to be enabled in the repo settings first.
There was a problem hiding this comment.
I do think its about enabling in the settings, but I am not an expert. Maybe it needs to go in the default branch first?
georgkrause
force-pushed
the
cicd
branch
15 times, most recently
from
de6129e to
a3af56e
Compare
This adds some automation to the project.
In order to make this work, we would need to setup a Trusted Publisher on Pypi for the project. The documentation is here: https://docs.pypi.org/trusted-publishers/