Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update on PyPI #24

Closed
phw opened this issue Dec 31, 2023 · 10 comments
Closed

Update on PyPI #24

phw opened this issue Dec 31, 2023 · 10 comments

Comments

@phw
Copy link
Member

phw commented Dec 31, 2023

Update this package on https://pypi.org/project/pylistenbrainz/

@georgkrause
Copy link
Collaborator

I just found this issue. I started working on automating the updating in #26

However, as far as I am aware there are some issues regarding the ownership that needs to be resolved first.

@georgkrause
Copy link
Collaborator

Alright, so since the access to the account managing the package on pypi got lost, I discusses with @mayhem if its feasible to rename the package. I think the least controversial suggestion have been pylistenbrainz, however this is open for discussion.

Renaming has some obvious disadvantages:

  • Users probably need to update their code to adjust the package name
  • Users of this package might don't notice there was a name change and don't receive expected updates anymore

This is what comes to my mind. I don't know who the responsible parties are, just let me know what you think!

@georgkrause
Copy link
Collaborator

@mayhem We could do a pre-release to test the pipeline and do a proper release afterwards so everyone can update the dependency. What do you think?

@georgkrause
Copy link
Collaborator

@phw Just a notice for you as author, pylistenbrainz is dead, the new package will be named liblistenbrainz

@mayhem
Copy link
Member

mayhem commented Jan 23, 2024

Just started with the pre-release --- lets see how it goes.

@mayhem
Copy link
Member

mayhem commented Jan 23, 2024

It failed -- are you able to see the results? How do we add the needed tokens?

@phw
Copy link
Member Author

phw commented Jan 23, 2024

@mayhem in pypi.org go to https://pypi.org/manage/project/liblistenbrainz/settings/publishing/ and add a new trusted publisher.

Repository: metabrainz/liblistenbrainz
Workflow: cd.yml
Environment name: can I think be left empty for the current setup

Not sure what would happen if the project does not yet exist on pypi, though. Might be this would need a manual publishing the very first time.

@phw
Copy link
Member Author

phw commented Jan 23, 2024

@mayhem Should work without project also, on https://pypi.org/manage/account/publishing/ . Just use "liblistenbrainz" as project name there.

@georgkrause
Copy link
Collaborator

Not sure what would happen if the project does not yet exist on pypi, though.

Just for completeness, the project would be created then. No manual intervention required

@phw
Copy link
Member Author

phw commented Jan 23, 2024

@phw phw closed this as completed Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants