Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MSC2630: checking public keys in SAS verification #2630

Merged
merged 8 commits into from
Jul 11, 2020
Merged

MSC2630: checking public keys in SAS verification #2630

merged 8 commits into from
Jul 11, 2020

Conversation

uhoreg
Copy link
Member

@uhoreg uhoreg commented Jun 11, 2020 •
edited by ara4n
Loading

@uhoreg uhoreg changed the title MSCxxxx: checking public keys in SAS verification MSC2630: checking public keys in SAS verification Jun 11, 2020
@uhoreg uhoreg added the proposal A matrix spec change proposal label Jun 11, 2020
@turt2live turt2live self-requested a review June 11, 2020 20:43
@ara4n
Copy link
Member

ara4n commented Jun 12, 2020

this got an OOB lgtm from @mimoo :)

@turt2live turt2live added kind:core MSC which is critical to the protocol's success proposal-in-review labels Jun 19, 2020
@uhoreg
Copy link
Member Author

uhoreg commented Jun 19, 2020

@mscbot fcp merge

@mscbot
Copy link
Collaborator

mscbot commented Jun 19, 2020 •
edited by dbkr
Loading

Team member @uhoreg has proposed to merge this. The next step is review by the rest of the tagged people:

Once at least 75% of reviewers approve (and there are no outstanding concerns), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for information about what commands tagged team members can give me.

@mscbot mscbot added disposition-merge proposed-final-comment-period Currently awaiting signoff of a majority of team members in order to enter the final comment period. labels Jun 19, 2020
turt2live
turt2live approved these changes Jun 19, 2020
View reviewed changes
Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks :D

@richvdh
Copy link
Member

richvdh commented Jun 23, 2020

I'll assume that others have considered the cryptographic aspects of this, looks fine from a spec POV

@mscbot
Copy link
Collaborator

mscbot commented Jul 6, 2020

🔔 This is now entering its final comment period, as per the review above. 🔔

@mscbot mscbot added final-comment-period This MSC has entered a final comment period in interest to approval, postpone, or delete in 5 days. and removed proposed-final-comment-period Currently awaiting signoff of a majority of team members in order to enter the final comment period. labels Jul 6, 2020
@mscbot
Copy link
Collaborator

mscbot commented Jul 11, 2020

The final comment period, with a disposition to merge, as per the review above, is now complete.

@mscbot mscbot added finished-final-comment-period and removed disposition-merge final-comment-period This MSC has entered a final comment period in interest to approval, postpone, or delete in 5 days. labels Jul 11, 2020
@turt2live turt2live merged commit e207dfc into matrix-org:master Jul 11, 2020
@uhoreg uhoreg mentioned this pull request Jul 13, 2020
Merged
@poljar poljar mentioned this pull request Jul 14, 2020
Closed
@uhoreg
Copy link
Member Author

uhoreg commented Jul 23, 2020

Merged! 🎉

@uhoreg uhoreg added the merged A proposal whose PR has merged into the spec! label Jul 23, 2020
@tulir tulir mentioned this pull request Jul 25, 2020
Merged
@baldo baldo mentioned this pull request Apr 4, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ara4n ara4n ara4n left review comments

@Sorunome Sorunome Sorunome left review comments

@turt2live turt2live turt2live approved these changes

Assignees
No one assigned
Labels
kind:core MSC which is critical to the protocol's success merged A proposal whose PR has merged into the spec! proposal A matrix spec change proposal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@uhoreg @ara4n @mscbot @richvdh @turt2live @Sorunome