document new key agreement method for SAS verification and deprecate old method #2687
Conversation
| @@ -0,0 +1 @@ | |||
| Document new key agreement method for SAS verification, and deprecate old method (MSC2630). | |||
There was a problem hiding this comment.
| Document new key agreement method for SAS verification, and deprecate old method (MSC2630). | |
| Document `curve25519-hkdf-sha256` key agreement method for SAS verification, and deprecate old method (MSC2630). |
There was a problem hiding this comment.
technically speaking, this is a breaking change. An existing client implementing the current version of the spec will be incompatible with a client implementing (only) the new version of the spec.
r0.6.0, r0.5.0, r0.3.0 and r0.1.0 all included minor breaking changes, and I'd propose doing much the same here.
What do others think?
There was a problem hiding this comment.
I think it's fine to remove the previous requirement of curve25519 always being present, but the same mistake should not be repeated by now requiring curve25519-hkdf-sha256 to always be present. Maybe the docs could say something like "for version r0.7.0, it is expected that client supports at least the curve25519-hkdf-sha256 key agreement protocol".
Spec for MSC2630
Changes are in this section: https://14127-24998719-gh.circle-artifacts.com/0/scripts/gen/client_server/unstable.html#short-authentication-string-sas-verification