This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Use rgba() to set dialog background #5901
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This seems to avoid issues where the opacity var wouldn't be picked up by yarn build Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
|
It's good to have this as a possible fix, but I'd sort of like to understand why |
|
I'll spend a bit of time today and time to work out what's happening here. |
|
Opened #5905 with my discoveries so far, seems to work if we stick to floats for opacity. @SimonBrandner, is there a version you prefer...? |
|
Nope, it doesn't matter and Micheal has already approved your PR anyway :D Thanks for looking into it Closing in favour of #5905 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #17036.
Previously we set the opacity in the theme files using a separate variable. But that seemed to cause problems because after the app was built using
yarn buildthe variable always was1%