Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New lightbox navigation buttons shown over room buttons #17036

Closed
waclaw66 opened this issue Apr 22, 2021 · 1 comment · Fixed by matrix-org/matrix-react-sdk#5905
Closed

New lightbox navigation buttons shown over room buttons #17036

waclaw66 opened this issue Apr 22, 2021 · 1 comment · Fixed by matrix-org/matrix-react-sdk#5905
Assignees
@jryans
Labels
A-Media P1 S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect X-Regression X-Release-Blocker

Comments

@waclaw66
Copy link
Contributor

waclaw66 commented Apr 22, 2021 •
edited
Loading

Description

New lightbox navigation buttons are shown over room buttons, they're mixed without background dimmed.

obrazek

#17014 (comment)

Steps to reproduce

  • just click the image

Version information

  • Platform: Element Web 1.7.26-rc.1
  • Browser: Firefox 89b2
  • OS: Windows 10
  • URL: private homeserver
@SimonBrandner SimonBrandner self-assigned this Apr 22, 2021
@SimonBrandner
Copy link
Contributor

I can repro on RC

@SimonBrandner SimonBrandner mentioned this issue Apr 22, 2021
Closed
@jryans jryans added X-Regression X-Release-Blocker A-Media P1 S-Major Severely degrades major functionality or product features, with no satisfactory workaround labels Apr 22, 2021
jryans added a commit to matrix-org/matrix-react-sdk that referenced this issue Apr 22, 2021
@jryans
Use floats for image background opacity
b332f6b 
It seems percentages for opacity are still newish, and they seem to confuse
something which is clamping them to the 0 - 1 range (which makes sense for
floats, not percentages).

Anyway, for now we can get what we want here by using float values.

Fixes element-hq/element-web#17036
@jryans jryans mentioned this issue Apr 22, 2021
Merged
@jryans jryans self-assigned this Apr 22, 2021
@SimonBrandner SimonBrandner removed their assignment Apr 22, 2021
jryans added a commit to matrix-org/matrix-react-sdk that referenced this issue Apr 22, 2021
@jryans
Use floats for image background opacity
d15e846 
It seems percentages for opacity are still newish, and they seem to confuse
something which is clamping them to the 0 - 1 range (which makes sense for
floats, not percentages).

Anyway, for now we can get what we want here by using float values.

Fixes element-hq/element-web#17036
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jryans jryans

Labels
A-Media P1 S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect X-Regression X-Release-Blocker
Projects
None yet
Milestone
No milestone
3 participants
@jryans @waclaw66 @SimonBrandner