This repository was archived by the owner on Aug 8, 2023. It is now read-only.
[WIP] Throw/notify on map loading error #3063
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Throw an Objective-C exception whenever mbgl encounters an error. (Developers are trained to break on Objective-C exceptions as opposed to C++ exceptions.) If mbgl is unable to set up the map and the delegate implements the map loading failure callback method, call that method instead of throwing the exception. ref #2762
1ec5
added
iOS
| @@ -202,6 +203,9 @@ - (void)setStyleURL:(nullable NSURL *)styleURL | |||
| - (void)commonInit | |||
| { | |||
| _isTargetingInterfaceBuilder = NSProcessInfo.processInfo.mgl_isInterfaceBuilderDesignablesAgent; | |||
|
|
|||
| std::unique_ptr<MGLLogObserver> logObserver = std::make_unique<MGLLogObserver>(self); | |||
| mbgl::Log::setObserver(std::move(logObserver)); | |||
There was a problem hiding this comment.
mbgl::Log is a singleton, so this approach won’t scale to multiple MGLMapViews.
|
I considered calling |
| bool onRecord(mbgl::EventSeverity severity, mbgl::Event event, int64_t code, const std::string &msg) | ||
| { | ||
| __block bool didNotifyDelegate = false; | ||
| if (severity == mbgl::EventSeverity::Error && event == mbgl::Event::Setup) |
There was a problem hiding this comment.
How closely does mbgl::Event::Setup correlate to map loading errors (as opposed to networking errors)?
There was a problem hiding this comment.
Currently, it’s only used inside MapContext::setStyleURL(), when the style itself fails to load due to a failed HTTP request. Is that consistent with what you outlined in #2775 (comment)?
|
Closing as stale. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Throw an Objective-C exception whenever mbgl encounters an error. (Developers are trained to break on Objective-C exceptions as opposed to C++ exceptions.) If mbgl is unable to set up the map and the delegate implements the map loading failure callback method, call that method instead of throwing the exception.
/ref #2762, #2775
/cc @friedbunny @incanus