Skip to content
This repository was archived by the owner on Aug 8, 2023. It is now read-only.

Map change errors/failures should be specified and passed through to platform SDKs #8086

Closed
ericrwolfe opened this issue Feb 16, 2017 · 3 comments
Labels
Core The cross-platform C++ core, aka mbgl MapKit parity For feature parity with MapKit on iOS or macOS
Milestone

Comments

@ericrwolfe
Copy link
Contributor

Currently map.cpp only returns single mbgl::MapChangeDidFailLoadingMap event for any and all map failures, making it impossible for a developer to distinguish between map failures.

For example, on iOS the same error is returned whether a map load failed due to a bad access token, a bad style, or a bad network connection.

/cc @1ec5

@ericrwolfe ericrwolfe added the Core The cross-platform C++ core, aka mbgl label Feb 16, 2017
@1ec5
Copy link
Contributor

1ec5 commented Feb 16, 2017

The error was implemented in #3063 to use a generic code and nil message because of this issue. As such, it’s debatable whether we’ve actually fixed #2762, and certainly this blocks #2775. mbgl notifications could be structs with richer information, but at that point we might as well start throwing real C++ exceptions and catching them at the SDK level, along the lines of #3063.

@1ec5
Copy link
Contributor

1ec5 commented Mar 16, 2017

This is happening in #8418.

@1ec5 1ec5 added the MapKit parity For feature parity with MapKit on iOS or macOS label Mar 16, 2017
@1ec5 1ec5 added this to the ios-v3.6.0 milestone Mar 16, 2017
@boundsj
Copy link
Contributor

boundsj commented Mar 22, 2017

#8418 landed in the master branch.

@boundsj boundsj closed this as completed Mar 22, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Core The cross-platform C++ core, aka mbgl MapKit parity For feature parity with MapKit on iOS or macOS
Projects
None yet
Development

No branches or pull requests

3 participants