Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Forwardport] [Resolved : Menu widget submenu alignment #7897] #15709 #15753

Conversation

hitesh-wagento
Copy link
Contributor

Original Pull Request

#15645

the submenu relative to the "Bottoms 2" element in the image should be aligned next to it

Description

Fixed Issues (if relevant)

  1. magento/magento2#Menu widget submenu alignment #7897: Issue title Menu widget submenu alignment

Manual testing scenarios

  1. hover a menu item which contains some nested elements

Actual Result

a241f354-c6ac-11e6-839a-48c5accde3da

Expected Result

expected-result

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

gelanivishal and others added 30 commits May 23, 2018 08:42
…te on results magento#15450

 - Merge Pull Request magento#15450 from dmanners/magento2:adding-manners-to-github-templates
 - Merged commits:
   1. 64b5f63
…alidComposer

Fixed issues:
- MAGETWO-86709 Widget isn't updated on Storefront if related Products are updated
- MAGETWO-89410 [2.3] Test testValidComposerJson fails on bundle extensions
- MAGETWO-87492 Rename 2.3 upgrade script
ankurseepossible and others added 22 commits June 2, 2018 09:51
…OptionPrice magento#15576

 - Merge Pull Request magento#15576 from osrecio/magento2:2.3-develop-PR-port-15276
 - Merged commits:
   1. 784099e
   2. 382d685
…nto#15660 magento#15682

 - Merge Pull Request magento#15682 from ankurvr/magento2:ankurvr-patch-2.3-develop
 - Merged commits:
   1. f5f3c76
   2. d696233
   3. 424324e
   4. eca36b2
   5. 98265ab
   6. ac220b7
   7. 12041e1
…to/framework/Data/… magento#15670

 - Merge Pull Request magento#15670 from vgelani/magento2:2.3-develop-PR-port-15336
 - Merged commits:
   1. 11923bc
 - Merge Pull Request magento#15667 from vgelani/magento2:2.3-develop-PR-port-15602
 - Merged commits:
   1. 2feaf30
…agento#15659

 - Merge Pull Request magento#15659 from DanielRuf/magento2:2.3-develop-PR-port-15305
 - Merged commits:
   1. 1113749


 - Merge Pull Request magento#15658 from vgelani/magento2:2.3-develop-PR-port-15398
 - Merged commits:
   1. 891fcdb
 - Merge Pull Request magento#15646 from vgelani/magento2:2.3-develop-PR-port-15549
 - Merged commits:
   1. 1d51097
Accepted Public Pull Requests:
 - magento#15646: [Forwardport] Fixed typo error (by @vgelani)
 - magento#15658: [Forwardport] Fixed set template syntax issue (by @vgelani)
 - magento#15659: [Forwardport] chore: remove extraneous cursor property (by @DanielRuf)
 - magento#15667: [Forwardport] set correct annotation (by @vgelani)
 - magento#15670: [Forwardport] Wrong annotation in _toOptionArray - magento/framework/Data/� (by @vgelani)
 - magento#15682: [Forwardport] Wrong Last orders amount on dashboard magento#15660 (by @ankurvr)
 - magento#15576: [Forwardport] [fix] typo in method name _getCharg[e]ableOptionPrice (by @osrecio)
 - magento#15623: Fix translations (by @cherednichenkoa)
 - magento#15478: [Forwardport] Removed mageMenu widget dependency from breadcrumbs component magento#15178 (by @vovayatsyuk)
 - magento#15177: Adding support for variadic arguments' method in generated proxy c� (by @bartek9007)


Fixed GitHub Issues:
 - magento#15601: Wrong annotation in formatDateTime - lib/internal/Magento/Framework/Stdlib/DateTime/TimezoneInterface.php (reported by @sanjay-wagento) has been fixed in magento#15667 by @vgelani in 2.3-develop branch
   Related commits:
     1. 2feaf30

 - magento#15601: Wrong annotation in formatDateTime - lib/internal/Magento/Framework/Stdlib/DateTime/TimezoneInterface.php (reported by @sanjay-wagento) has been fixed in magento#15670 by @vgelani in 2.3-develop branch
   Related commits:
     1. 11923bc

 - magento#15660: Wrong order amount on dashboard on Last orders listing when having more than one website with different currencies (reported by @ankurvr) has been fixed in magento#15682 by @ankurvr in 2.3-develop branch
   Related commits:
     1. f5f3c76
     2. d696233
     3. 424324e
     4. eca36b2
     5. 98265ab
     6. ac220b7
     7. 12041e1

 - magento#14987: Invisible breadcrumbs at product page when mageMenu widget is not used (reported by @vovayatsyuk) has been fixed in magento#15478 by @vovayatsyuk in 2.3-develop branch
   Related commits:
     1. 7b1d1b6
     2. fd03f7c
…ct-join-query

[borg] MAGETWO-45950: Product ResourceCollection wrong Join Query
@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Jun 4, 2018

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 12 committers have signed the CLA.

✅ vgelani
❌ magento-engcom-team
❌ svitja
❌ StasKozar
❌ zakdma
❌ facundocapua
❌ DianaRusin
❌ saravananvelu
❌ NadiyaS
❌ danielrenaud
❌ magento-cicd2
❌ slavvka

@magento-engcom-team magento-engcom-team added Partner: Wagento Pull Request is created by partner Wagento partners-contribution Pull Request is created by Magento Partner Component: AdminNotification labels Jun 4, 2018
@VladimirZaets
Copy link
Contributor

Hi @hitesh-wagento. Looks like something went wrong. As I see you try to deliver the fix to 2.2-develop from the branch that based on 2.3-develop. Please move your changes to branch that based on 2.2-develop and create new one PR.
Thanks.

@hitesh-wagento hitesh-wagento deleted the feature-menu-widget-submenu-m.2.3 branch June 4, 2018 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Frontend Component: AdminNotification Partner: Wagento Pull Request is created by partner Wagento partners-contribution Pull Request is created by Magento Partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.