Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Forwardport] Removed mageMenu widget dependency from breadcrumbs component #15178 #15478

Conversation

vovayatsyuk
Copy link
Member

This is a cherry-pick of #15178

Description

For now, breadcrumbs on the product page hardly rely on mageMenu widget. This commit completely removes this dependency to allow to use third-party menus.

Fixed Issues

  1. Invisible breadcrumbs at product page when mageMenu widget is not used #14987: Invisible breadcrumbs at product page when mageMenu widget is not used

Manual testing scenarios

  1. Open app/code/Magento/Theme/view/frontend/templates/html/topmenu.phtml
  2. Remove the following code from the template:
data-mage-init='{"menu":{"responsive":true, "expanded":true, "position":{"my":"left top","at":"left bottom"}}}'
  1. Navigate to the product page.
  2. Breadcrumbs are not rendered.

Comments

  • I removed categoryId from the crumb name, since links id is a random number generated by jQueryUI menu. It has nothing to actual category id.
  • Two tests where removed, because I removed _init method completely

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@VladimirZaets
Copy link
Contributor

Hi @vovayatsyuk , thank you for collaboration. Please resolve conflicts in your branch.

@VladimirZaets VladimirZaets self-assigned this May 29, 2018
@VladimirZaets
Copy link
Contributor

@vovayatsyuk thanks

@magento-engcom-team
Copy link
Contributor

Hi @vovayatsyuk. Thank you for your contribution.
Changes from your Pull Request will be available with the upcoming 2.3.0 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants