Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Magento 2 Paypal Reauthorization Issue #9336

Closed
shahankitb997 opened this issue Apr 21, 2017 · 6 comments
Closed

Magento 2 Paypal Reauthorization Issue #9336

shahankitb997 opened this issue Apr 21, 2017 · 6 comments
Assignees
Labels
bug report Component: Payment Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development

Comments

@shahankitb997
Copy link

shahankitb997 commented Apr 21, 2017

  1. Using Magento 2.1.6 CE
  2. Go to magento\vendor\magento\module-paypal\Model\Api\Nvp.php
public function callDoReauthorization()
{
	$request = $this->_export($this->_doReauthorizationRequest);
	$response = $this->call('DoReauthorization', $request);
	$this->_import($response, $this->_doReauthorizationResponse);
}

Instead of $request = $this->_export($this->_doReauthorizationRequest);
It should Use $request = $this->__exportToRequest($this->_doReauthorizationRequest);

&

Instead of $this->_import($response, $this->_doReauthorizationResponse);
It should Use $this->_importFromResponse($this->_doReauthorizationResponse, $response);

Right would be

public function callDoReauthorization()
{
	$request = $this->_exportToRequest($this->_doReauthorizationRequest);
	$response = $this->call('DoReauthorization', $request);
	$this->_importFromResponse($this->_doReauthorizationResponse, $response);
}

@magento-admin @magento-team

@YevSent
Copy link
Contributor

YevSent commented Apr 21, 2017

Hi, @shahankitb997, thanks for reporting. I've created internal ticket (MAGETWO-67632).

@ladle3000
Copy link

Is this issue what causes long checkout time with PayPal pro credit cards?

@shahankitb997
Copy link
Author

shahankitb997 commented May 2, 2017

Hi @snoroozi not sure about this. Using Paypal Express Checkout. But #9442 returns needed variable or not. need to check.

Thanks

@shahankitb997
Copy link
Author

shahankitb997 commented May 4, 2017

Hi @snoroozi While we do Reauthorization we have new Expiry Date of that Authorized Payment. Where Magento is storing that new expiry date? In sales_payment_transaction not able to find

Is it keep tracking of old & new expiry date. Because you can reauthorize transaction multiple time.

@magento-admin @magento-team

magento-team pushed a commit that referenced this issue Jul 3, 2017
Issues fixed:
- MAGETWO-65422 Write default configs to shared configuration file by app:config:dump
- MAGETWO-69567 [Mainline] - Closing the image view window causes mini-cart to drop down
- MAGETWO-69607 Edition Specific BN-Codes for 2.2.x
- MAGETWO-68936 Billing Agreement page is not loaded if Vault enabled
- MAGETWO-57975 Impossible use ExtensionInterfaceFactory
- MAGETWO-69580 Unstable automated test Magento\Paypal\Test\TestCase\InContextExpressOnePageCheckoutTest failed on variation InContextExpressOnePageCheckoutTestVariation1
- MAGETWO-69110 Incorrect status for order placed within Authorize.net with Fraud Filters Triggered (Filter Actions = Process as normal and report filter(s) triggered)
- MAGETWO-68949 [Github] "We Can't Place The Order" error #9455
- MAGETWO-69112 No request sent to Authorize.net after reordering order in admin
- MAGETWO-69584 Command config:sensitive:set does not work on the cloud
- MAGETWO-57846 [Github] New Order Status config in payment method is useless #5860
- MAGETWO-67632 [Github] Invalid method usage in PayPal NVP callDoReauthorization method #9336
- MAGETWO-63239 [GITHUB] No possibility to save payment transaction details
- MAGETWO-69121 Loader doesn't disappear if Authorize.net transact.dll fails request
- MAGETWO-64518 \Magento\CatalogRule\Model\Indexer\IndexBuilder method "doReindexFull()" causes temporary missing sale prices
- MAGETWO-60533 Data passed to Magento\Framework\ObjectManager\Config\Compiled is not validated
- MAGETWO-70061 Exception on EE installation on environment with default-storage-engine=MyISAM
- MAGETWO-69260 Unable to create shipping label due to error of lb to kg conversion
- MAGETWO-58961 Multiselect text values are not searchable using QuickSearch with ElasticSearch
- MQE-155 [FT] Magento\UrlRewrite\Test\TestCase\CreateProductWithSeveralWebsitesUrlRewriteTest randomly fails on Jenkins
@YevSent
Copy link
Contributor

YevSent commented Jul 3, 2017

Hi, @shahankitb997, the fix merged into the develop branch.

@YevSent YevSent closed this as completed Jul 3, 2017
@ladle3000
Copy link

ladle3000 commented Jul 3, 2017 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug report Component: Payment Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development
Projects
None yet
Development

No branches or pull requests

4 participants