-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[2.2.0-RC2.2] Static content deploy with multiple locales: js-translation.json files are the same #10673
Comments
Thanks for reporting - internal issue is MAGETWO-72301 |
@hostep, thank you for your report. |
Will be fixed in 2.2.1 |
Hello. So you can see it's appending all the locales to the end of the :deploy. What we've had to do as a workaround is override this class and introduce a foreach performing a setup:static-content:deploy on every locale in the $this->getUsedLocales() array. |
@tadhgbowe: you can find a better workaround in: #7862, that's the issue for tracking this problem in 2.1.x |
Internal ticket to track issue progress: MAGETWO-82752 |
nope - this is not fixed in 2.2.1 |
…js-translation.json files are the same #10673
Still an issue in 2.2.1 I've been searching for several hours now (well, it's magento, what else would you expect) and finally came up with a solution. deployment before: This resulted in 3 equal js-translation.json files, where en_US and cs_CZ also contained the labels of the first translation de_DE If you do separate deployment calls for each language it works as expected.
I also made a small shell script which simplifies this process, in case anyone is interested. deploy.sh
|
still not fixed in 2.2.2 |
@Blueblazer172 it does seem to be working with v2.2.2 for our setup using |
Can confirm this issue is fixed in version 2.2.2, closing. Thanks @wert2all! |
Any news here? Still reproduced in 2.3.x 😕 commit was merged only to 2.2 branch |
…3 and through 2.2.2 or possible up to but not including 2.3.0 Indicator of being fixed in 2.2.2 and later: magento/magento2#10673 (comment) Indicator of it being fixed in 2.3.0 and later: magento/magento2#10913 Related to magento/magento2#7862 which is now closed as resolved in 2.2.x somewhere
Still reproduced in 2.4.3 |
Preconditions
Steps to reproduce
composer require honl/magento2-nl-nl imaginaerum/magento2-language-fr-fr
Dutch (Netherlands)
andFrench (France)
for those 2 storeviewsphp bin/magento setup:static-content:deploy -f -t Magento/luma nl_NL && php bin/magento setup:static-content:deploy -f -t Magento/luma fr_FR
diff -rwq pub/static/frontend/Magento/luma/nl_NL/ pub/static/frontend/Magento/luma/fr_FR/
Files pub/static/frontend/Magento/luma/nl_NL/js-translation.json and pub/static/frontend/Magento/luma/fr_FR/js-translation.json differ
=> Goodrm -R pub/static/* var/view_preprocessed/*
php bin/magento setup:static-content:deploy -f -t Magento/luma nl_NL fr_FR
diff -rwq pub/static/frontend/Magento/luma/nl_NL/ pub/static/frontend/Magento/luma/fr_FR/
Expected result
js-translation.json
files should be differentActual result
js-translation.json
files are the sameThis has as result that all javascript translations are in the wrong locale on the frontend.
Discussion
This is the same issue like I reported on #7862 for Magento 2.1.3, but this was supposed to be fixed by MAGETWO-62660, which is included in Magento 2.2.0-RC2.2, but looks like that didn't really help, or something else might broke it yet again ...
The text was updated successfully, but these errors were encountered: