Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to translate strings using javascript dictionary #12722

Closed
alena-marchenko opened this issue Dec 14, 2017 · 7 comments
Closed

Unable to translate strings using javascript dictionary #12722

alena-marchenko opened this issue Dec 14, 2017 · 7 comments
Assignees
Labels
bug report Component: Translation Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release

Comments

@alena-marchenko
Copy link

alena-marchenko commented Dec 14, 2017

Preconditions

  1. Magento is installed from 2.2-develop branch
  2. Default or Developer mode
  3. 2 custom Store Views created and enabled
  4. All indexers are valid
  5. Different locales are set for each Store View, for example:
  • Ukrainian (Ukraine) for the 1st custom Store View
  • French (France) for the 2nd custom Store View
  • Leave English (United States) on Default Config level to be extended as a locale for Default Store View
  1. Magento Cache is flushed if there is a need
  2. Product visible for all Store Views is created
  3. Put attached CSV files to Magento root folder
    source_fr_FR.csv.zip
    source_uk_UA.csv.zip
  4. Run following in console:
  • bin/magento i18n:pack --mode=replace -d source_uk_UA.csv uk_UA
  • bin/magento i18n:pack --mode=replace -d source_fr_FR.csv fr_FR
  • bin/magento setup:static-content:deploy en_US uk_UA fr_FR -f
  • bin/magento setup:di:compile
  • bin/magento deploy:mode:set production -s

Steps to reproduce

  1. Go to Storefront
  2. Switch to Storeview with French locale
  3. Open product page
  4. Click Ajouter au panier to add the product to cart

Expected result

Button changes to Ajout... while the ajax request is processing
When the ajax requests is finished, the button changes to Ajouté
After a bit of time, the button changes back to Ajouter au panier

Actual result

Default string Adding... appears instead of Ajout...
Default string Added appears instead of Ajouté

@alena-marchenko alena-marchenko added bug report Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Component: Translation mageconf Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release labels Dec 14, 2017
@Tomasz-Silpion
Copy link
Member

See #8508 (I managed to resolve similar issue there with code left in comments) and #10673

I believe it's already described as MAGETOTWO-72301 and there's already fix for the problem developed in fc34d7b

@andrewbess
Copy link

#mageconf

@magento-engcom-team
Copy link
Contributor

@andrewbess thank you for joining. Please accept team invitation here and self-assign the issue.

@okorshenko
Copy link
Contributor

Hi @andrewbess please accept the invite https://github.com/orgs/magento/invitation

@andrewbess andrewbess self-assigned this Dec 15, 2017
@andrewbess
Copy link

This bug is not reproduced following this steps.
But the system has another bug with translations.
It is a wrong translated string(s) for "fr_FR" locale.

Expected result:
Button changes to "En cours d'ajout..." while the ajax request is processing
When the ajax requests is finished, the button changes to "Produit ajouté"
After a bit of time, the button changes back to "Ajouter au panier"

Actual result:
Wrong translated string "Ajouter vos mots clés :" appears instead of "Produit ajouté"
Translated strings for "uk_UA" locale are correct.

Screenshots:
https://ibb.co/iemXem
https://ibb.co/e0QfX6

@ishakhsuvarov
Copy link
Contributor

Closing this issue per comment above.
Ticket for updated translation issue: #12782

@ishakhsuvarov
Copy link
Contributor

@andrewbess Thank you for verifying the issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug report Component: Translation Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release
Projects
None yet
Development

No branches or pull requests

6 participants