-
-
Notifications
You must be signed in to change notification settings - Fork 692
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add ski-jump icon #2516
add ski-jump icon #2516
Conversation
Added or changed iconsIcons as codeWorks for: const SkiJumpIcon = createLucideIcon('SkiJump', [
["path",{"d":"m12 19 1.53-1.55a1.594 1.594 0 0 0-.4-2.53l-2.64-1.37a2 2 0 0 1-.86-2.69l1.09-2.12a2 2 0 0 1 2.63-.84l.05.03a2 2 0 0 1 .86 2.7 1278 1278 0 0 0-1.99 3.84"}],
["path",{"d":"m3 23 17.72-2.82a4 4 0 0 0 2-.93L23 19"}],
["path",{"d":"M6 8 3 19"}],
["path",{"d":"m9.39 8.93-1.58-.79a2 2 0 0 0-.89-.21H5.39"}],
["circle",{"cx":"14.85","cy":"5.12","r":"2.05"}]
]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Should be bigger
- Should be centered
- Has pretty sharp corners, should be rounder "lucidy-er"
skijump
should beski-jump
or evenski-jumper
- The head should have a radius of at least 2px IMO
- The person should be bigger in general IMO, @jamiemlaw had the great suggestion for people styles: fix(icons): added
person
and reworkedperson-standing
icon #2496 (comment) - Curves should be arcs example.
Hi, I've implemented the changes you suggested:
Please let me know if there's anything else you'd like me to tweak. |
One fault with my person design (which I copied from GitHub!) is that I'm not sure how well it translates to smaller side-on figures. I have previously tried a wheelchair user and a cyclist, neither of which looked that good. Here's a possible alternative. It has no ski poles, in part to reduce clutter and I also haven't seen any other ski jump icons with poles; it's more aligned to the grid, it has at least one-pixel gap around each edge; and there's a two-pixel gap between the skier and the skis. I don't think it's perfect, though, but it's something. |
What is the purpose of this pull request?
Description
Added New ski-jump icon
Icon use case
Alternative icon designs
Icon Design Checklist
Concept
Author, credits & license
Naming
icons/[iconName].json
.Design
Before Submitting