Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(icons): added person and reworked person-standing icon #2496

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

jguddas
Copy link
Member

@jguddas jguddas commented Sep 26, 2024

What is the purpose of this pull request?

  • Other: Icon update

Description

Redesigned the person-standing icon.

  • Adjusted size.
  • Added roundness.
  • Increased head size to remove gap violation.

Before Submitting

@github-actions github-actions bot added 🎨 icon About new icons 🫧 metadata Improved metadata labels Sep 26, 2024
Copy link

github-actions bot commented Sep 26, 2024

Added or changed icons

icons/person.svgicons/person-arms-out.svg

Preview cohesion icons/square-arrow-left.svgicons/square-dashed-mouse-pointer.svg
icons/person.svgicons/person-arms-out.svg
icons/pyramid.svgicons/arrow-down-right.svg
Preview stroke widths icons/person.svgicons/person-arms-out.svg
icons/person.svgicons/person-arms-out.svg
icons/person.svgicons/person-arms-out.svg
DPI Preview (24px) icons/person.svg icons/person-arms-out.svg
Icon X-rays icons/person.svg icons/person-arms-out.svg
Icon Diffs icons/person.svg icons/person-arms-out.svg
Icons as code

Works for: lucide-react, lucide-react-native, lucide-preact, lucide-vue-next

const PersonIcon = createLucideIcon('Person', [
  ["path",{"d":"M14.828 10H15a4 4 0 0 1 4 4v1"}],
  ["path",{"d":"M15 17H9"}],
  ["path",{"d":"M15 22V11a3 3 0 0 0-6 0v11"}],
  ["path",{"d":"M9.172 10H9a4 4 0 0 0-4 4v1"}],
  ["circle",{"cx":"12","cy":"5","r":"3"}]
])

const PersonArmsOutIcon = createLucideIcon('PersonArmsOut', [
  ["path",{"d":"M15.55 17h-7.1"}],
  ["path",{"d":"m16 22-1.012-11.268a3 3 0 0 0-5.976 0L8 22"}],
  ["path",{"d":"m21 9-6.012 1.732"}],
  ["path",{"d":"M9.012 10.732 3 9"}],
  ["circle",{"cx":"12","cy":"5","r":"3"}]
])

@karsa-mistmere
Copy link
Member

karsa-mistmere commented Sep 26, 2024

image

Sorry, but I'm afraid this design is still a thumbs down from me. 🫣

(Plus, for a redesign, we'd also have to take into consideration compatibility with #609 )

@jguddas
Copy link
Member Author

jguddas commented Sep 26, 2024

I think it's more lucidy and has fewer guideline violation, it doesn't need to be perfect.

@jamiemlaw
Copy link
Contributor

For reference, GitHub's accessibility icon uses this kind of design:

image

icons
Open lucide studio

And a very crude representation of that style of figure walking:

icons
Open lucide studio

@jamiemlaw
Copy link
Contributor

jamiemlaw commented Sep 26, 2024

A few more ideas for consideration, just to have in the backlog:

icons
Open lucide studio

icons
Open lucide studio

icons
Open lucide studio

icons
Open lucide studio

Obviously not the last one!

@jguddas
Copy link
Member Author

jguddas commented Sep 26, 2024

What about a wheelchair user and cyclist variant?

@jamiemlaw
Copy link
Contributor

For the wheelchair, I'm thinking something like this but it might require some extra work.

icons
Open lucide studio

There would also need to be a version for a wheelchair user on the move.

For the cyclist, I've seen some of the past attempts by other users in this repo. Here's where my head's currently at:

image

@jguddas jguddas mentioned this pull request Oct 5, 2024
23 tasks
@jamiemlaw jamiemlaw mentioned this pull request Oct 9, 2024
5 tasks
@karsa-mistmere
Copy link
Member

The current primary (intended) use case of this icon is to represent accessibility, this redesign does not fulfil this use case:
image

As such, I'm against it.

@jguddas
Copy link
Member Author

jguddas commented Oct 9, 2024

The current primary (intended) use case of this icon is to represent accessibility, this redesign does not fulfil this use case: image

As such, I'm against it.

Why does it not fulfill that use case, it's literally used that way on GitHub?

image

But yes, the accessibility icon in a lot of places is based on Vitruvian Man.
I'm not opposed to adding a circle-person-standing, I'm actually quite in favor #921, hehe.

@jamiemlaw
Copy link
Contributor

I'm torn on the issue.

Some icon designs look much better to me in the stick figure style, e.g. wheelchair user, cyclist; but others like standing, walking and running feel way more "Lucide"-y in the fatter outline style.

In any case, here are some potentially suitable stick figure designs, with ever-increasing leg gap. I'm favouring the last two.

icons icons icons icons icons

Or taller still?

icons icons

@jguddas
Copy link
Member Author

jguddas commented Oct 15, 2024

I love the GitHub-y version, what I struggle with is consistency, how are we gonna manage to update the cyclist and wheelchair-user to feel just as awesome?

@jguddas
Copy link
Member Author

jguddas commented Oct 15, 2024

I'm torn on the issue.

Some icon designs look much better to me in the stick figure style, e.g. wheelchair user, cyclist; but others like standing, walking and running feel way more "Lucide"-y in the fatter outline style.

In any case, here are some potentially suitable stick figure designs, with ever-increasing leg gap. I'm favouring the last two.

icons icons icons icons icons

Or taller still?

icons icons

The stick figure version also feels a bit male to me, while the GitHub-y version feels quite a bit more gender neutral.

@jguddas
Copy link
Member Author

jguddas commented Nov 1, 2024

I love this GitHub-y version and want us to merge this 🙏

@ericfennis
Copy link
Member

I agree with @jamiemlaw on this one, I like the stick figures more.

Can we do a vote on this one?

@jguddas
Copy link
Member Author

jguddas commented Nov 8, 2024

I agree with @jamiemlaw on this one, I like the stick figures more.

Can we do a vote on this one?

The stick figure has a guideline violation of not having a 2px gap in the head, and I hate that.
It also just generally feels male, and I prefer the GitHub-y one due to being more gender-neutral.

@jamiemlaw
Copy link
Contributor

My vote:

In the case of icons representing wheelchair accessibility or universal access, because these are somewhat brand-like (i.e. well-recognised, standardised), I think they should probably remain as stick figures.

However, I think that the outline style of person should also be added, and people can choose to use it as an accessibility icon if they so choose.

If I were to be really pedantic:

  • person-standing - change that to this icon: a person standing, arms down person-standing. Or even change it to person and make person-standing an alias.
  • accessibility - keep as is, the dynamic wheelchair icon. accessibility
  • universal-access - whatever the new stick figure design becomes, rename it to this, as I think that's how the symbol originated, a design from Apple. universal-access
  • person-arms-out - add the new outline figure under this name (or similar), and give it a tag of access, accessibility. image

@jguddas
Copy link
Member Author

jguddas commented Nov 8, 2024

My vote:

In the case of icons representing wheelchair accessibility or universal access, because these are somewhat brand-like (i.e. well-recognised, standardised), I think they should probably remain as stick figures.

However, I think that the outline style of person should also be added, and people can choose to use it as an accessibility icon if they so choose.

If I were to be really pedantic:

  • person-standing - change that to this icon: a person standing, arms down person-standing. Or even change it to person and make person-standing an alias.
  • accessibility - keep as is, the dynamic wheelchair icon. accessibility
  • universal-access - whatever the new stick figure design becomes, rename it to this, as I think that's how the symbol originated, a design from Apple. universal-access
  • person-arms-out - add the new outline figure under this name (or similar), and give it a tag of access, accessibility. image

We should not be recreating copy righted works, be it the wheelchair user or universal access symbol.

In short, I am trying to get rid of the wheelchair icon, but it's hard since it's quite useful, just like the brand icons are quite useful.

I do like your idea of creating a person icon + person-arms-out icon.

@jguddas jguddas changed the title fix(icons): changed person-standing icon fix(icons): added person and reworked person-standing icon Nov 9, 2024
Copy link

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the Stale label Dec 10, 2024
@jguddas jguddas mentioned this pull request Feb 25, 2025
5 tasks
@jguddas
Copy link
Member Author

jguddas commented Mar 8, 2025

Accessibility icon in firefox dev tools:
image

@jamiemlaw
Copy link
Contributor

Another idea for a wheelchair user:

wheelchair@2x wheelchair

icons
Open lucide studio

Certainly an improvement on my previous attempt, but still not sure how well it works at low-res.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎨 icon About new icons 🫧 metadata Improved metadata
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants