-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[lit][ci] Publish lit wheels #88072
[lit][ci] Publish lit wheels #88072
Conversation
Add wheel publishing in addition to existing source distribution publishing of lit. Fixes llvm#63369. Signed-off-by: Schuyler Eldridge <schuyler.eldridge@sifive.com>
@llvm/pr-subscribers-github-workflow Author: Schuyler Eldridge (seldridge) ChangesAdd wheel publishing in addition to existing source distribution publishing of lit. Fixes #63369. This also uses the exact fix proposed by @EFord36 in #63369. I was testing it on my branch (with a further modified version of CI that avoids some of the problematic GitHub Actions steps for a fork and adds debug information about what was built) only to make sure that this produces the expected files. That can be observed here: https://github.com/seldridge/llvm-project/actions/runs/8608056297/job/23589700846#step:7:1 There would now be a My use case for this is slightly different from #63369. I would like to use Full diff: https://github.com/llvm/llvm-project/pull/88072.diff 1 Files Affected:
diff --git a/.github/workflows/release-lit.yml b/.github/workflows/release-lit.yml
index 36b0b6edd518fc..0316ba406041d6 100644
--- a/.github/workflows/release-lit.yml
+++ b/.github/workflows/release-lit.yml
@@ -58,7 +58,7 @@ jobs:
cd llvm/utils/lit
# Remove 'dev' suffix from lit version.
sed -i 's/ + "dev"//g' lit/__init__.py
- python3 setup.py sdist
+ python3 setup.py sdist bdist_wheel
- name: Upload lit to test.pypi.org
uses: pypa/gh-action-pypi-publish@release/v1
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems fine to me
Thanks for the review @tru. |
Add wheel publishing in addition to existing source distribution publishing of lit. Fixes llvm#63369. This also uses the exact fix proposed by @EFord36 in llvm#63369. Signed-off-by: Schuyler Eldridge <schuyler.eldridge@sifive.com> (cherry picked from commit 8a8ab8f)
Add wheel publishing in addition to existing source distribution publishing of lit. Fixes llvm#63369. This also uses the exact fix proposed by @EFord36 in llvm#63369. Signed-off-by: Schuyler Eldridge <schuyler.eldridge@sifive.com> (cherry picked from commit 8a8ab8f)
Add wheel publishing in addition to existing source distribution publishing of lit.
Fixes #63369. This also uses the exact fix proposed by @EFord36 in #63369.
I was testing it on my branch (with a further modified version of CI that avoids some of the problematic GitHub Actions steps for a fork and adds debug information about what was built) only to make sure that this produces the expected files. That can be observed here: https://github.com/seldridge/llvm-project/actions/runs/8608056297/job/23589700846#step:7:1 There would now be a
lit-18.1.0-py3-none-any.whl
in addition to alit-18.1.0.tar.gz
.My use case for this is slightly different from #63369. I would like to use
lit
for an internal project. However, the internal project uses a build system which doesn't have support for building source dependencies except when using--no-use-pep517
.lit
, however, specifies abuild-backend
in itspyproject.toml
whichpip
treats as explicit opt-in topep517
even when the command line opt-out is provided.