[flang] Set compile definitions for flang-rt build on AIX #127919
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kkwli
changed the title
Meinersbur
approved these changes
Feb 21, 2025
There was a problem hiding this comment.
Would this otherwise come from
llvm-project/llvm/CMakeLists.txt
Line 1189 in 0181af2
Besides such global configuration changes not conforming modern CMake, this didn't work for standalone Flang builds either.
Yes, it is from there. |
Meinersbur
reviewed
Feb 22, 2025
Co-authored-by: Michael Kruse <github@meinersbur.de>
I will take a look of it. |
joaosaffran
pushed a commit
to joaosaffran/llvm-project
that referenced
this pull request
Feb 27, 2025
After commit b55f751, the flang-rt build on AIX is missing `-D_LARGE_FILE_API -D_XOPEN_SOURCE=700` in compiling the source. This patch is to add the compile definitions. --------- Co-authored-by: Michael Kruse <github@meinersbur.de>
YutongZhuu
pushed a commit
to YutongZhuu/llvm-project
that referenced
this pull request
Mar 8, 2025
After commit b55f751, the flang-rt build on AIX is missing `-D_LARGE_FILE_API -D_XOPEN_SOURCE=700` in compiling the source. This patch is to add the compile definitions. --------- Co-authored-by: Michael Kruse <github@meinersbur.de>
YutongZhuu
pushed a commit
to YutongZhuu/llvm-project
that referenced
this pull request
Mar 8, 2025
After commit b55f751, the flang-rt build on AIX is missing `-D_LARGE_FILE_API -D_XOPEN_SOURCE=700` in compiling the source. This patch is to add the compile definitions. --------- Co-authored-by: Michael Kruse <github@meinersbur.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After b55f751 (PR #110217), the flang-rt build on AIX is missing
-D_LARGE_FILE_API -D_XOPEN_SOURCE=700in compiling the source. This patch is to add the compile definitions.