[Flang] LLVM_ENABLE_RUNTIMES=flang-rt #110217

Meinersbur · 2024-09-27T07:52:43Z

Extract Flang's runtime library to use the LLVM_ENABLE_RUNTIME mechanism. It will only become active when LLVM_ENABLE_RUNTIMES=flang-rt is used, which also changes the FLANG_INCLUDE_RUNTIME to OFF so the old runtime build rules do not conflict. This also means that unless LLVM_ENABLE_RUNTIMES=flang-rt is passed, nothing changes.

Motivation:

Consistency with LLVM's other runtime libraries (compiler-rt, libc, libcxx, openmp offload, ...)
Allows compiling the runtime for multiple targets at once using the LLVM_RUNTIME_TARGETS configuration options
Installs the runtime into the compiler's per-target resource directory so it can be automatically found even when cross-compiling

Potential future directions:

Uses CMake's support for compiling Fortran files, including dependency resolution of Fortran modules
Improve robustness of compiling libomp.mod when openmp is available
Remove Flang's dependency from flang-rt's RTNAME function declarations (tblgen?)
Reduce Flang's build-time dependency from flang-rt's REAL(16) support

See RFC discussion at https://discourse.llvm.org/t/rfc-use-llvm-enable-runtimes-for-flangs-runtime/80826

Patch series:

Patch for lab.llvm.org buildbots:

Enable Flang-RT for all Flang builders. llvm-zorg#333

github-actions · 2024-10-01T13:48:55Z

✅ With the latest revision this PR passed the Python code formatter.

github-actions · 2024-10-01T13:48:55Z

✅ With the latest revision this PR passed the C/C++ code formatter.

Meinersbur · 2024-10-01T15:39:01Z

I reverted the change that moved flang/module/*.f90 to FortranRuntime/module/*.f90. A lot of Flang tests depend on the *.mod files to be available. Moving the modules to FortranRuntime would either require moving those tests to FortranRuntime as well, or mark them as requiring the module_files (REQUIRES: module_files) and build those before check-flang:

flowchart TB
 subgraph Flang
   direction TB
   flang-new
   check-flang
 end
 subgraph FortranRuntime
   direction TB
   iso_fortran_env_impl("iso_fortran_env_impl.f90")
   lib("libFortranRuntime.a")
   module_files
   check-FortranRuntime
 end

 flang-new --> iso_fortran_env_impl --> lib --> check-FortranRuntime
 flang-new --> module_files --> check-flang
 flang-new --> check-flang
 flang-new --> check-FortranRuntime

Except the PPC modules, the mod files are not target-specific and hence would not profit from compiling multiple targets from a bootstrap build anyway. However, they are products of the Flang compiler and therefore IMHO logically fits better to the runtime. Also, it would have been nice to make use of CMake's dependency resolution rather than hardcoding Into the CMakeLists.txt. I think it is best to keep that decision out of the current patch.

Due to missing lit.cfg, will only be executing again after #110217.

FortranRuntime/lib/Runtime/CMakeLists.txt

FortranRuntime/CMakeLists.txt

llvm/cmake/modules/LLVMExternalProjectUtils.cmake

llvm/runtimes/CMakeLists.txt

flang/lib/Evaluate/common.cpp

llvm/cmake/modules/LLVMExternalProjectUtils.cmake

runtimes/CMakeLists.txt

llvm/runtimes/CMakeLists.txt

ldionne

I think the global setting of flags is the last comment I have from the perspective of "integration with the runtimes build". I haven't reviewed anything else inside flang-rt/ though.

flang-rt/CMakeLists.txt

jplehr · 2024-10-31T09:40:02Z

I tested this locally and it appears that it requires are more modern CMake version than what was installed (3.22).
According to the LLVM docs (https://releases.llvm.org/12.0.0/docs/GettingStarted.html#id8) currently CMake 3.20 is the minimum required version.

flang-rt/CMakeLists.txt

llvm/runtimes/CMakeLists.txt

llvm/cmake/modules/LLVMExternalProjectUtils.cmake

jhuber6 · 2024-11-07T16:11:14Z

Overall I think the patch is fine pending some naming nits, my one concern is the -U__GLIBCXX stuff, because undefining internal vars seems really sketchy. Do we use -nostdlib++ to make sure we don't link the C++ library?

jeanPerier · 2024-11-08T14:53:42Z

~~When building the runtime out of tree and running check-flang-rt, I am seeing an error about LLVM header not found~~

edit: My -DLLVM_DIR was incorrect, never mind.

jeanPerier

Thanks for addressing all my concerns! Let's roll!

Meinersbur · 2025-02-13T14:58:21Z

The pre-merge tests are failing. AFAICS, these are issues with the Buildkite bots, not with this PR.

buildkite/libcxx-ci/aarch64(-fno-exceptons): timeouts
buildkite/github-pull-requests/linux-linux-x64 and /windows-windows-x64: Linux reports failing to create the directory include/flang. The Windows error is ninja: error: FindFirstFileExA(include/flang): The directory name is invalid.. This seems to be an instance of "error: FindFirstFileExA(...): The directory name is invalid." when directory in .ninja_deps changes to regular file on Windows ninja-build/ninja#2159 and hints that in both cases, "include/flang" is a file (instead of a directory as expected).

I don't see include/flang being a file in my local tests build directory (it contains the .mod files), I am assuming this is a leftover from some previous build on the buildbot. Plus, this PR doesn't change anything about how the module files are being built.

…inersbur/flang_runtime_move-files

…einersbur/flang_runtime

It actually is needed to run llvm-test-suite from a bootstrap build clang/flang.

…einersbur/flang_runtime

Meinersbur · 2025-02-14T08:40:57Z

buildkite/github-pull-requests/linux-linux-x64 and /windows-windows-x64: Linux reports failing to create the directory flang/include. The Windows error is ninja: error: FindFirstFileExA(include/flang): The directory name is invalid.. This seems to be an instance of "error: FindFirstFileExA(...): The directory name is invalid." when directory in .ninja_deps changes to regular file on Windows ninja-build/ninja#2159 and hints that in both cases, "include/flang" is a file (instead of a directory as expected).

This was a case of configure_file behaving like cp: If you specify a target path, if that target is a directory, put the file into that directory. If it does not exist, then the target path is the new file.

Also merged-in 660cdac that cause a build failure.

Mostly mechanical changes in preparation of extracting the Flang-RT "subproject" in #110217. This PR intends to only move pre-existing files to the new folder structure, with no behavioral change. Common files (headers, testing, cmake) shared by Flang-RT and Flang remain in `flang/`. Some cosmetic changes and files paths were necessary: * Relative paths to the new path for the source files and `add_subdirectory`. * Add the new location's include directory to `include_directories` * The unittest/Evaluate directory has unitests for flang-rt and Flang. A new `CMakeLists.txt` was introduced for the flang-rt tests. * Change the `#include` paths relative to the include directive * clang-format on the `#include` directives * Since the paths are part if the copyright header and include guards, a script was used to canonicalize those * `test/Runtime` and runtime tests in `test/Driver` are moved, but the lit.cfg.py mechanism to execute the will only be added in #110217.

…einersbur/flang_runtime

llvm-ci · 2025-02-16T15:47:31Z

LLVM Buildbot has detected a new failure on builder clang-cmake-x86_64-avx512-win running on avx512-intel64-win while building flang-rt,flang,llvm,runtimes at step 6 "ninja check 1".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/81/builds/4789

Here is the relevant piece of the build log for the reference

Step 6 (ninja check 1) failure: stage 1 checked (failure)
******************** TEST 'Clang :: Driver/offload-Xarch.c' FAILED ********************
Exit Code: 1

Command Output (stdout):
--
# RUN: at line 3
d:\buildbot\llvm-worker\clang-cmake-x86_64-avx512-win\stage1\bin\clang.exe --target=x86_64-unknown-linux-gnu -x cuda D:\buildbot\llvm-worker\clang-cmake-x86_64-avx512-win\llvm\clang\test\Driver\offload-Xarch.c -Xarch_nvptx64 -O3 -S -nogpulib -nogpuinc -### 2>&1 | d:\buildbot\llvm-worker\clang-cmake-x86_64-avx512-win\stage1\bin\filecheck.exe -check-prefix=O3ONCE D:\buildbot\llvm-worker\clang-cmake-x86_64-avx512-win\llvm\clang\test\Driver\offload-Xarch.c
# executed command: 'd:\buildbot\llvm-worker\clang-cmake-x86_64-avx512-win\stage1\bin\clang.exe' --target=x86_64-unknown-linux-gnu -x cuda 'D:\buildbot\llvm-worker\clang-cmake-x86_64-avx512-win\llvm\clang\test\Driver\offload-Xarch.c' -Xarch_nvptx64 -O3 -S -nogpulib -nogpuinc '-###'
# executed command: 'd:\buildbot\llvm-worker\clang-cmake-x86_64-avx512-win\stage1\bin\filecheck.exe' -check-prefix=O3ONCE 'D:\buildbot\llvm-worker\clang-cmake-x86_64-avx512-win\llvm\clang\test\Driver\offload-Xarch.c'
# RUN: at line 4
d:\buildbot\llvm-worker\clang-cmake-x86_64-avx512-win\stage1\bin\clang.exe -x cuda D:\buildbot\llvm-worker\clang-cmake-x86_64-avx512-win\llvm\clang\test\Driver\offload-Xarch.c -Xarch_device -O3 -S -nogpulib -nogpuinc -### 2>&1 | d:\buildbot\llvm-worker\clang-cmake-x86_64-avx512-win\stage1\bin\filecheck.exe -check-prefix=O3ONCE D:\buildbot\llvm-worker\clang-cmake-x86_64-avx512-win\llvm\clang\test\Driver\offload-Xarch.c
# executed command: 'd:\buildbot\llvm-worker\clang-cmake-x86_64-avx512-win\stage1\bin\clang.exe' -x cuda 'D:\buildbot\llvm-worker\clang-cmake-x86_64-avx512-win\llvm\clang\test\Driver\offload-Xarch.c' -Xarch_device -O3 -S -nogpulib -nogpuinc '-###'
# executed command: 'd:\buildbot\llvm-worker\clang-cmake-x86_64-avx512-win\stage1\bin\filecheck.exe' -check-prefix=O3ONCE 'D:\buildbot\llvm-worker\clang-cmake-x86_64-avx512-win\llvm\clang\test\Driver\offload-Xarch.c'
# RUN: at line 5
d:\buildbot\llvm-worker\clang-cmake-x86_64-avx512-win\stage1\bin\clang.exe -x hip D:\buildbot\llvm-worker\clang-cmake-x86_64-avx512-win\llvm\clang\test\Driver\offload-Xarch.c -Xarch_amdgcn -O3 -S -nogpulib -nogpuinc -### 2>&1 | d:\buildbot\llvm-worker\clang-cmake-x86_64-avx512-win\stage1\bin\filecheck.exe -check-prefix=O3ONCE D:\buildbot\llvm-worker\clang-cmake-x86_64-avx512-win\llvm\clang\test\Driver\offload-Xarch.c
# executed command: 'd:\buildbot\llvm-worker\clang-cmake-x86_64-avx512-win\stage1\bin\clang.exe' -x hip 'D:\buildbot\llvm-worker\clang-cmake-x86_64-avx512-win\llvm\clang\test\Driver\offload-Xarch.c' -Xarch_amdgcn -O3 -S -nogpulib -nogpuinc '-###'
# executed command: 'd:\buildbot\llvm-worker\clang-cmake-x86_64-avx512-win\stage1\bin\filecheck.exe' -check-prefix=O3ONCE 'D:\buildbot\llvm-worker\clang-cmake-x86_64-avx512-win\llvm\clang\test\Driver\offload-Xarch.c'
# RUN: at line 6
d:\buildbot\llvm-worker\clang-cmake-x86_64-avx512-win\stage1\bin\clang.exe -fopenmp=libomp -fopenmp-targets=amdgcn-amd-amdhsa -nogpulib -nogpuinc    -Xarch_amdgcn -march=gfx90a -Xarch_amdgcn -O3 -S -### D:\buildbot\llvm-worker\clang-cmake-x86_64-avx512-win\llvm\clang\test\Driver\offload-Xarch.c 2>&1  | d:\buildbot\llvm-worker\clang-cmake-x86_64-avx512-win\stage1\bin\filecheck.exe -check-prefix=O3ONCE D:\buildbot\llvm-worker\clang-cmake-x86_64-avx512-win\llvm\clang\test\Driver\offload-Xarch.c
# executed command: 'd:\buildbot\llvm-worker\clang-cmake-x86_64-avx512-win\stage1\bin\clang.exe' -fopenmp=libomp -fopenmp-targets=amdgcn-amd-amdhsa -nogpulib -nogpuinc -Xarch_amdgcn -march=gfx90a -Xarch_amdgcn -O3 -S '-###' 'D:\buildbot\llvm-worker\clang-cmake-x86_64-avx512-win\llvm\clang\test\Driver\offload-Xarch.c'
# executed command: 'd:\buildbot\llvm-worker\clang-cmake-x86_64-avx512-win\stage1\bin\filecheck.exe' -check-prefix=O3ONCE 'D:\buildbot\llvm-worker\clang-cmake-x86_64-avx512-win\llvm\clang\test\Driver\offload-Xarch.c'
# RUN: at line 9
d:\buildbot\llvm-worker\clang-cmake-x86_64-avx512-win\stage1\bin\clang.exe -fopenmp=libomp -fopenmp-targets=nvptx64-nvidia-cuda -nogpulib -nogpuinc    -Xarch_nvptx64 -march=sm_52 -Xarch_nvptx64 -O3 -S -### D:\buildbot\llvm-worker\clang-cmake-x86_64-avx512-win\llvm\clang\test\Driver\offload-Xarch.c 2>&1  | d:\buildbot\llvm-worker\clang-cmake-x86_64-avx512-win\stage1\bin\filecheck.exe -check-prefix=O3ONCE D:\buildbot\llvm-worker\clang-cmake-x86_64-avx512-win\llvm\clang\test\Driver\offload-Xarch.c
# executed command: 'd:\buildbot\llvm-worker\clang-cmake-x86_64-avx512-win\stage1\bin\clang.exe' -fopenmp=libomp -fopenmp-targets=nvptx64-nvidia-cuda -nogpulib -nogpuinc -Xarch_nvptx64 -march=sm_52 -Xarch_nvptx64 -O3 -S '-###' 'D:\buildbot\llvm-worker\clang-cmake-x86_64-avx512-win\llvm\clang\test\Driver\offload-Xarch.c'
# executed command: 'd:\buildbot\llvm-worker\clang-cmake-x86_64-avx512-win\stage1\bin\filecheck.exe' -check-prefix=O3ONCE 'D:\buildbot\llvm-worker\clang-cmake-x86_64-avx512-win\llvm\clang\test\Driver\offload-Xarch.c'
# RUN: at line 15
d:\buildbot\llvm-worker\clang-cmake-x86_64-avx512-win\stage1\bin\clang.exe -fopenmp=libomp -fopenmp-targets=nvptx64-nvidia-cuda,amdgcn-amd-amdhsa -nogpulib    --target=x86_64-unknown-linux-gnu -Xopenmp-target=nvptx64-nvidia-cuda --offload-arch=sm_52,sm_60 -nogpuinc    -Xopenmp-target=amdgcn-amd-amdhsa --offload-arch=gfx90a,gfx1030 -ccc-print-bindings -### D:\buildbot\llvm-worker\clang-cmake-x86_64-avx512-win\llvm\clang\test\Driver\offload-Xarch.c 2>&1  | d:\buildbot\llvm-worker\clang-cmake-x86_64-avx512-win\stage1\bin\filecheck.exe -check-prefix=OPENMP D:\buildbot\llvm-worker\clang-cmake-x86_64-avx512-win\llvm\clang\test\Driver\offload-Xarch.c
# executed command: 'd:\buildbot\llvm-worker\clang-cmake-x86_64-avx512-win\stage1\bin\clang.exe' -fopenmp=libomp -fopenmp-targets=nvptx64-nvidia-cuda,amdgcn-amd-amdhsa -nogpulib --target=x86_64-unknown-linux-gnu -Xopenmp-target=nvptx64-nvidia-cuda --offload-arch=sm_52,sm_60 -nogpuinc -Xopenmp-target=amdgcn-amd-amdhsa --offload-arch=gfx90a,gfx1030 -ccc-print-bindings '-###' 'D:\buildbot\llvm-worker\clang-cmake-x86_64-avx512-win\llvm\clang\test\Driver\offload-Xarch.c'
# executed command: 'd:\buildbot\llvm-worker\clang-cmake-x86_64-avx512-win\stage1\bin\filecheck.exe' -check-prefix=OPENMP 'D:\buildbot\llvm-worker\clang-cmake-x86_64-avx512-win\llvm\clang\test\Driver\offload-Xarch.c'
# RUN: at line 31
d:\buildbot\llvm-worker\clang-cmake-x86_64-avx512-win\stage1\bin\clang.exe -x cuda D:\buildbot\llvm-worker\clang-cmake-x86_64-avx512-win\llvm\clang\test\Driver\offload-Xarch.c --offload-arch=sm_52,sm_60 -Xarch_sm_52 -O3 -Xarch_sm_60 -O0    --target=x86_64-unknown-linux-gnu -Xarch_host -O3 -S -nogpulib -nogpuinc -### 2>&1  | d:\buildbot\llvm-worker\clang-cmake-x86_64-avx512-win\stage1\bin\filecheck.exe -check-prefix=CUDA D:\buildbot\llvm-worker\clang-cmake-x86_64-avx512-win\llvm\clang\test\Driver\offload-Xarch.c
# executed command: 'd:\buildbot\llvm-worker\clang-cmake-x86_64-avx512-win\stage1\bin\clang.exe' -x cuda 'D:\buildbot\llvm-worker\clang-cmake-x86_64-avx512-win\llvm\clang\test\Driver\offload-Xarch.c' --offload-arch=sm_52,sm_60 -Xarch_sm_52 -O3 -Xarch_sm_60 -O0 --target=x86_64-unknown-linux-gnu -Xarch_host -O3 -S -nogpulib -nogpuinc '-###'
# executed command: 'd:\buildbot\llvm-worker\clang-cmake-x86_64-avx512-win\stage1\bin\filecheck.exe' -check-prefix=CUDA 'D:\buildbot\llvm-worker\clang-cmake-x86_64-avx512-win\llvm\clang\test\Driver\offload-Xarch.c'
# RUN: at line 39
d:\buildbot\llvm-worker\clang-cmake-x86_64-avx512-win\stage1\bin\clang.exe -fopenmp=libomp --offload-arch=gfx90a -nogpulib -nogpuinc    --target=x86_64-unknown-linux-gnu -Xarch_amdgcn -Wl,-lfoo -### D:\buildbot\llvm-worker\clang-cmake-x86_64-avx512-win\llvm\clang\test\Driver\offload-Xarch.c 2>&1  | d:\buildbot\llvm-worker\clang-cmake-x86_64-avx512-win\stage1\bin\filecheck.exe -check-prefix=LIBS D:\buildbot\llvm-worker\clang-cmake-x86_64-avx512-win\llvm\clang\test\Driver\offload-Xarch.c
# executed command: 'd:\buildbot\llvm-worker\clang-cmake-x86_64-avx512-win\stage1\bin\clang.exe' -fopenmp=libomp --offload-arch=gfx90a -nogpulib -nogpuinc --target=x86_64-unknown-linux-gnu -Xarch_amdgcn -Wl,-lfoo '-###' 'D:\buildbot\llvm-worker\clang-cmake-x86_64-avx512-win\llvm\clang\test\Driver\offload-Xarch.c'
# executed command: 'd:\buildbot\llvm-worker\clang-cmake-x86_64-avx512-win\stage1\bin\filecheck.exe' -check-prefix=LIBS 'D:\buildbot\llvm-worker\clang-cmake-x86_64-avx512-win\llvm\clang\test\Driver\offload-Xarch.c'
# .---command stderr------------
# | D:\buildbot\llvm-worker\clang-cmake-x86_64-avx512-win\llvm\clang\test\Driver\offload-Xarch.c:45:10: error: LIBS: expected string not found in input
# | // LIBS: "--device-linker=amdgcn-amd-amdhsa=-lfoo"
# |          ^
# | <stdin>:1:1: note: scanning from here
# | clang version 21.0.0git (https://github.com/llvm/llvm-project.git b55f7512a76f2358000139074c79d4c2521588de)
# | ^
# | <stdin>:6:1442: note: possible intended match here
# |  "D:\\buildbot\\llvm-worker\\clang-cmake-x86_64-avx512-win\\stage1\\bin\\clang.exe" "-cc1" "-triple" "x86_64-unknown-linux-gnu" "-emit-llvm-bc" "-emit-llvm-uselists" "-dumpdir" "a-" "-disable-free" "-clear-ast-before-backend" "-main-file-name" "offload-Xarch.c" "-mrelocation-model" "pic" "-pic-level" "2" "-pic-is-pie" "-mframe-pointer=all" "-fmath-errno" "-ffp-contract=on" "-fno-rounding-math" "-mconstructor-aliases" "-funwind-tables=2" "-target-cpu" "x86-64" "-tune-cpu" "generic" "-debugger-tuning=gdb" "-fdebug-compilation-dir=D:\\buildbot\\llvm-worker\\clang-cmake-x86_64-avx512-win\\stage1\\tools\\clang\\test\\Driver" "-fcoverage-compilation-dir=D:\\buildbot\\llvm-worker\\clang-cmake-x86_64-avx512-win\\stage1\\tools\\clang\\test\\Driver" "-resource-dir" "D:\\buildbot\\llvm-worker\\clang-cmake-x86_64-avx512-win\\stage1\\lib\\clang\\21" "-internal-isystem" "D:\\buildbot\\llvm-worker\\clang-cmake-x86_64-avx512-win\\stage1\\lib\\clang\\21\\include" "-internal-isystem" "/usr/local/include" "-internal-externc-isystem" "/include" "-internal-externc-isystem" "/usr/include" "-internal-isystem" "D:\\buildbot\\llvm-worker\\clang-cmake-x86_64-avx512-win\\stage1\\lib\\clang\\21\\include" "-internal-isystem" "/usr/local/include" "-internal-externc-isystem" "/include" "-internal-externc-isystem" "/usr/include" "-ferror-limit" "19" "-fopenmp" "--no-offloadlib" "-fgnuc-version=4.2.1" "-fskip-odr-check-in-gmf" "-disable-llvm-passes" "-fopenmp-targets=amdgcn-amd-amdhsa" "-faddrsig" "-D__GCC_HAVE_DWARF2_CFI_ASM=1" "-o" "C:\\Users\\tianfei\\AppData\\Local\\Temp\\1\\lit-tmp-ne0o3wyg\\offload-Xarch-644509.bc" "-x" "c" "D:\\buildbot\\llvm-worker\\clang-cmake-x86_64-avx512-win\\llvm\\clang\\test\\Driver\\offload-Xarch.c"
# |                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                  ^
# | 
# | Input file: <stdin>
# | Check file: D:\buildbot\llvm-worker\clang-cmake-x86_64-avx512-win\llvm\clang\test\Driver\offload-Xarch.c
...

llvm-ci · 2025-02-16T15:52:37Z

LLVM Buildbot has detected a new failure on builder lldb-aarch64-windows running on linaro-armv8-windows-msvc-05 while building flang-rt,flang,llvm,runtimes at step 6 "test".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/141/builds/6341

Here is the relevant piece of the build log for the reference

Step 6 (test) failure: build (failure)
...
PASS: lldb-api :: commands/platform/file/close/TestPlatformFileClose.py (177 of 2084)
PASS: lldb-api :: commands/platform/file/read/TestPlatformFileRead.py (178 of 2084)
XFAIL: lldb-api :: commands/platform/connect/TestPlatformConnect.py (179 of 2084)
UNSUPPORTED: lldb-api :: commands/platform/launchgdbserver/TestPlatformLaunchGDBServer.py (180 of 2084)
UNSUPPORTED: lldb-api :: commands/platform/process/list/TestProcessList.py (181 of 2084)
UNSUPPORTED: lldb-api :: commands/platform/sdk/TestPlatformSDK.py (182 of 2084)
UNSUPPORTED: lldb-api :: commands/process/attach-resume/TestAttachResume.py (183 of 2084)
PASS: lldb-api :: commands/platform/process/launch/TestPlatformProcessLaunch.py (184 of 2084)
UNSUPPORTED: lldb-api :: commands/process/attach/attach_denied/TestAttachDenied.py (185 of 2084)
PASS: lldb-api :: commands/process/continue_to_bkpt/TestContinueToBkpts.py (186 of 2084)
FAIL: lldb-api :: commands/process/detach-resumes/TestDetachResumes.py (187 of 2084)
******************** TEST 'lldb-api :: commands/process/detach-resumes/TestDetachResumes.py' FAILED ********************
Script:
--
C:/Users/tcwg/scoop/apps/python/current/python.exe C:/Users/tcwg/llvm-worker/lldb-aarch64-windows/llvm-project/lldb\test\API\dotest.py -u CXXFLAGS -u CFLAGS --env LLVM_LIBS_DIR=C:/Users/tcwg/llvm-worker/lldb-aarch64-windows/build/./lib --env LLVM_INCLUDE_DIR=C:/Users/tcwg/llvm-worker/lldb-aarch64-windows/build/include --env LLVM_TOOLS_DIR=C:/Users/tcwg/llvm-worker/lldb-aarch64-windows/build/./bin --arch aarch64 --build-dir C:/Users/tcwg/llvm-worker/lldb-aarch64-windows/build/lldb-test-build.noindex --lldb-module-cache-dir C:/Users/tcwg/llvm-worker/lldb-aarch64-windows/build/lldb-test-build.noindex/module-cache-lldb\lldb-api --clang-module-cache-dir C:/Users/tcwg/llvm-worker/lldb-aarch64-windows/build/lldb-test-build.noindex/module-cache-clang\lldb-api --executable C:/Users/tcwg/llvm-worker/lldb-aarch64-windows/build/./bin/lldb.exe --compiler C:/Users/tcwg/llvm-worker/lldb-aarch64-windows/build/./bin/clang.exe --dsymutil C:/Users/tcwg/llvm-worker/lldb-aarch64-windows/build/./bin/dsymutil.exe --make C:/Users/tcwg/scoop/shims/make.exe --llvm-tools-dir C:/Users/tcwg/llvm-worker/lldb-aarch64-windows/build/./bin --lldb-obj-root C:/Users/tcwg/llvm-worker/lldb-aarch64-windows/build/tools/lldb --lldb-libs-dir C:/Users/tcwg/llvm-worker/lldb-aarch64-windows/build/./lib --skip-category=watchpoint C:\Users\tcwg\llvm-worker\lldb-aarch64-windows\llvm-project\lldb\test\API\commands\process\detach-resumes -p TestDetachResumes.py
--
Exit Code: 1

Command Output (stdout):
--
lldb version 21.0.0git (https://github.com/llvm/llvm-project.git revision b55f7512a76f2358000139074c79d4c2521588de)
  clang revision b55f7512a76f2358000139074c79d4c2521588de
  llvm revision b55f7512a76f2358000139074c79d4c2521588de
Skipping the following test categories: ['watchpoint', 'libc++', 'libstdcxx', 'dwo', 'dsym', 'gmodules', 'debugserver', 'objc', 'fork', 'pexpect']


--
Command Output (stderr):
--
ls: cannot access 'C:\Users\tcwg\llvm-worker\lldb-aarch64-windows\build\lldb-test-build.noindex\commands\process\detach-resumes\TestDetachResumes.test_detach_resumes\exit_file_1739719944': No such file or directory
ls: cannot access 'C:\Users\tcwg\llvm-worker\lldb-aarch64-windows\build\lldb-test-build.noindex\commands\process\detach-resumes\TestDetachResumes.test_detach_resumes\exit_file_1739719944': No such file or directory
ls: cannot access 'C:\Users\tcwg\llvm-worker\lldb-aarch64-windows\build\lldb-test-build.noindex\commands\process\detach-resumes\TestDetachResumes.test_detach_resumes\exit_file_1739719944': No such file or directory
ls: cannot access 'C:\Users\tcwg\llvm-worker\lldb-aarch64-windows\build\lldb-test-build.noindex\commands\process\detach-resumes\TestDetachResumes.test_detach_resumes\exit_file_1739719944': No such file or directory
ls: cannot access 'C:\Users\tcwg\llvm-worker\lldb-aarch64-windows\build\lldb-test-build.noindex\commands\process\detach-resumes\TestDetachResumes.test_detach_resumes\exit_file_1739719944': No such file or directory
ls: cannot access 'C:\Users\tcwg\llvm-worker\lldb-aarch64-windows\build\lldb-test-build.noindex\commands\process\detach-resumes\TestDetachResumes.test_detach_resumes\exit_file_1739719944': No such file or directory
FAIL: LLDB (C:\Users\tcwg\llvm-worker\lldb-aarch64-windows\build\bin\clang.exe-aarch64) :: test_detach_resumes (TestDetachResumes.DetachResumesTestCase.test_detach_resumes)

======================================================================

FAIL: test_detach_resumes (TestDetachResumes.DetachResumesTestCase.test_detach_resumes)

----------------------------------------------------------------------

Traceback (most recent call last):

  File "C:\Users\tcwg\llvm-worker\lldb-aarch64-windows\llvm-project\lldb\test\API\commands\process\detach-resumes\TestDetachResumes.py", line 59, in test_detach_resumes

    lldbutil.wait_for_file_on_target(self, exit_file_path)

h-vetinari · 2025-02-17T04:39:16Z

Congratulations on getting this big piece of work merged! 👏 🥳

I'll start rebuilding from main after LLVM 20.1 is GA

Mostly mechanical changes in preparation of extracting the Flang-RT "subproject" in llvm#110217. This PR intends to only move pre-existing files to the new folder structure, with no behavioral change. Common files (headers, testing, cmake) shared by Flang-RT and Flang remain in `flang/`. Some cosmetic changes and files paths were necessary: * Relative paths to the new path for the source files and `add_subdirectory`. * Add the new location's include directory to `include_directories` * The unittest/Evaluate directory has unitests for flang-rt and Flang. A new `CMakeLists.txt` was introduced for the flang-rt tests. * Change the `#include` paths relative to the include directive * clang-format on the `#include` directives * Since the paths are part if the copyright header and include guards, a script was used to canonicalize those * `test/Runtime` and runtime tests in `test/Driver` are moved, but the lit.cfg.py mechanism to execute the will only be added in llvm#110217.

Extract Flang's runtime library to use the LLVM_ENABLE_RUNTIME mechanism. It will only become active when `LLVM_ENABLE_RUNTIMES=flang-rt` is used, which also changes the `FLANG_INCLUDE_RUNTIME` to `OFF` so the old runtime build rules do not conflict. This also means that unless `LLVM_ENABLE_RUNTIMES=flang-rt` is passed, nothing changes with the current build process. Motivation: * Consistency with LLVM's other runtime libraries (compiler-rt, libc, libcxx, openmp offload, ...) * Allows compiling the runtime for multiple targets at once using the LLVM_RUNTIME_TARGETS configuration options * Installs the runtime into the compiler's per-target resource directory so it can be automatically found even when cross-compiling Also see RFC discussion at https://discourse.llvm.org/t/rfc-use-llvm-enable-runtimes-for-flangs-runtime/80826

Mostly mechanical changes in preparation of extracting the Flang-RT "subproject" in llvm#110217. This PR intends to only move pre-existing files to the new folder structure, with no behavioral change. Common files (headers, testing, cmake) shared by Flang-RT and Flang remain in `flang/`. Some cosmetic changes and files paths were necessary: * Relative paths to the new path for the source files and `add_subdirectory`. * Add the new location's include directory to `include_directories` * The unittest/Evaluate directory has unitests for flang-rt and Flang. A new `CMakeLists.txt` was introduced for the flang-rt tests. * Change the `#include` paths relative to the include directive * clang-format on the `#include` directives * Since the paths are part if the copyright header and include guards, a script was used to canonicalize those * `test/Runtime` and runtime tests in `test/Driver` are moved, but the lit.cfg.py mechanism to execute the will only be added in llvm#110217.

Extract Flang's runtime library to use the LLVM_ENABLE_RUNTIME mechanism. It will only become active when `LLVM_ENABLE_RUNTIMES=flang-rt` is used, which also changes the `FLANG_INCLUDE_RUNTIME` to `OFF` so the old runtime build rules do not conflict. This also means that unless `LLVM_ENABLE_RUNTIMES=flang-rt` is passed, nothing changes with the current build process. Motivation: * Consistency with LLVM's other runtime libraries (compiler-rt, libc, libcxx, openmp offload, ...) * Allows compiling the runtime for multiple targets at once using the LLVM_RUNTIME_TARGETS configuration options * Installs the runtime into the compiler's per-target resource directory so it can be automatically found even when cross-compiling Also see RFC discussion at https://discourse.llvm.org/t/rfc-use-llvm-enable-runtimes-for-flangs-runtime/80826

Mostly mechanical changes in preparation of extracting the Flang-RT "subproject" in llvm#110217. This PR intends to only move pre-existing files to the new folder structure, with no behavioral change. Common files (headers, testing, cmake) shared by Flang-RT and Flang remain in `flang/`. Some cosmetic changes and files paths were necessary: * Relative paths to the new path for the source files and `add_subdirectory`. * Add the new location's include directory to `include_directories` * The unittest/Evaluate directory has unitests for flang-rt and Flang. A new `CMakeLists.txt` was introduced for the flang-rt tests. * Change the `#include` paths relative to the include directive * clang-format on the `#include` directives * Since the paths are part if the copyright header and include guards, a script was used to canonicalize those * `test/Runtime` and runtime tests in `test/Driver` are moved, but the lit.cfg.py mechanism to execute the will only be added in llvm#110217.

Extract Flang's runtime library to use the LLVM_ENABLE_RUNTIME mechanism. It will only become active when `LLVM_ENABLE_RUNTIMES=flang-rt` is used, which also changes the `FLANG_INCLUDE_RUNTIME` to `OFF` so the old runtime build rules do not conflict. This also means that unless `LLVM_ENABLE_RUNTIMES=flang-rt` is passed, nothing changes with the current build process. Motivation: * Consistency with LLVM's other runtime libraries (compiler-rt, libc, libcxx, openmp offload, ...) * Allows compiling the runtime for multiple targets at once using the LLVM_RUNTIME_TARGETS configuration options * Installs the runtime into the compiler's per-target resource directory so it can be automatically found even when cross-compiling Also see RFC discussion at https://discourse.llvm.org/t/rfc-use-llvm-enable-runtimes-for-flangs-runtime/80826

This was referenced Sep 27, 2024

[Flang][NFC] Split common headers to reduce dependencies. #110244

Merged

[Flang][NFC] Move runtime library files to flang-rt. #110298

Merged

Meinersbur changed the base branch from main to users/meinersbur/flang_runtime_move-files September 27, 2024 18:58

Meinersbur added a commit that referenced this pull request Oct 7, 2024

Move runtime tests

8b984fe

Due to missing lit.cfg, will only be executing again after #110217.

Meinersbur marked this pull request as ready for review October 7, 2024 20:57

Meinersbur requested a review from a team as a code owner October 7, 2024 20:57

Meinersbur changed the title ~~[Flang][DRAFT] LLVM_ENABLE_RUNTIMES=FortranRuntime~~ [Flang] LLVM_ENABLE_RUNTIMES=FortranRuntime Oct 7, 2024

vzakhari reviewed Oct 8, 2024

View reviewed changes

FortranRuntime/lib/Runtime/CMakeLists.txt Outdated Show resolved Hide resolved

ldionne previously requested changes Oct 10, 2024

View reviewed changes

FortranRuntime/CMakeLists.txt Outdated Show resolved Hide resolved

llvm/cmake/modules/LLVMExternalProjectUtils.cmake Show resolved Hide resolved

llvm/runtimes/CMakeLists.txt Outdated Show resolved Hide resolved

Meinersbur mentioned this pull request Oct 14, 2024

[Flang][NFC] Split runtime headers in preparation for cross-compilation. #112188

Merged

Meinersbur requested review from klausler, mjklemm, clementval, jplehr, tblah, vzakhari and ldionne October 16, 2024 10:28

klausler reviewed Oct 16, 2024

View reviewed changes

flang/lib/Evaluate/common.cpp Outdated Show resolved Hide resolved

ldionne reviewed Oct 16, 2024

View reviewed changes

llvm/cmake/modules/LLVMExternalProjectUtils.cmake Show resolved Hide resolved

runtimes/CMakeLists.txt Show resolved Hide resolved

llvm/runtimes/CMakeLists.txt Outdated Show resolved Hide resolved

ldionne reviewed Oct 21, 2024

View reviewed changes

flang-rt/CMakeLists.txt Outdated Show resolved Hide resolved

Meinersbur requested a review from jhuber6 November 6, 2024 14:36

jhuber6 reviewed Nov 6, 2024

View reviewed changes

flang-rt/CMakeLists.txt Outdated Show resolved Hide resolved

flang-rt/CMakeLists.txt Outdated Show resolved Hide resolved

llvm/runtimes/CMakeLists.txt Show resolved Hide resolved

llvm/cmake/modules/LLVMExternalProjectUtils.cmake Outdated Show resolved Hide resolved

jhuber6 changed the title ~~[Flang] LLVM_ENABLE_RUNTIMES=FortranRuntime~~ [Flang] LLVM_ENABLE_RUNTIMES=flang-rt Nov 6, 2024

Meinersbur requested a review from sscalpone November 7, 2024 15:48

jeanPerier approved these changes Feb 13, 2025

View reviewed changes

jhuber6 approved these changes Feb 13, 2025

View reviewed changes

Meinersbur added 7 commits February 13, 2025 19:49

Undo llvm-test-suite workaround

1796827

Merge commit '660cdace559a8dbe44ebf2222b854bf3f39a5f62' into users/me…

b12d925

…inersbur/flang_runtime_move-files

Merge branch 'users/meinersbur/flang_runtime_move-files' into users/m…

ff761f6

…einersbur/flang_runtime

Post-merge fixes

1ee1300

Re-apply llvm-test-suite workaround

c7d6b01

It actually is needed to run llvm-test-suite from a bootstrap build clang/flang.

Post-merge fixes

2f21466

Merge branch 'users/meinersbur/flang_runtime_move-files' into users/m…

c9a7900

…einersbur/flang_runtime

Base automatically changed from users/meinersbur/flang_runtime_move-files to main February 16, 2025 12:25

Meinersbur added 2 commits February 16, 2025 13:27

Merge branch 'main' into users/meinersbur/flang_runtime_move-files

c2c7bb2

Merge branch 'users/meinersbur/flang_runtime_move-files' into users/m…

6fa8982

…einersbur/flang_runtime

Meinersbur merged commit b55f751 into main Feb 16, 2025
73 of 76 checks passed

Meinersbur deleted the users/meinersbur/flang_runtime branch February 16, 2025 14:39

kkwli mentioned this pull request Feb 20, 2025

[flang] Set compile definitions for flang-rt build on AIX #127919

Merged

This was referenced Feb 21, 2025

LLVM_ENABLE_RUNTIMES=flang-rt for ClangBuilder builders llvm/llvm-zorg#386

Merged

[Flang] Remove FLANG_INCLUDE_RUNTIME #124126

Draft

Meinersbur mentioned this pull request Feb 26, 2025

[Flang] Driver hardcodes lib/libflang_rt.a path that is incorrect on lib64 systems, and does not permit multilib #127538

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Flang] LLVM_ENABLE_RUNTIMES=flang-rt #110217

[Flang] LLVM_ENABLE_RUNTIMES=flang-rt #110217

Meinersbur commented Sep 27, 2024 •

edited

Loading

github-actions bot commented Oct 1, 2024 •

edited

Loading

github-actions bot commented Oct 1, 2024 •

edited

Loading

Meinersbur commented Oct 1, 2024 •

edited

Loading

ldionne left a comment

jplehr commented Oct 31, 2024

jhuber6 commented Nov 7, 2024

jeanPerier commented Nov 8, 2024 •

edited

Loading

jeanPerier left a comment

Meinersbur commented Feb 13, 2025 •

edited

Loading

Meinersbur commented Feb 14, 2025

llvm-ci commented Feb 16, 2025

llvm-ci commented Feb 16, 2025

h-vetinari commented Feb 17, 2025

[Flang] LLVM_ENABLE_RUNTIMES=flang-rt #110217

[Flang] LLVM_ENABLE_RUNTIMES=flang-rt #110217

Conversation

Meinersbur commented Sep 27, 2024 • edited Loading

github-actions bot commented Oct 1, 2024 • edited Loading

github-actions bot commented Oct 1, 2024 • edited Loading

Meinersbur commented Oct 1, 2024 • edited Loading

ldionne left a comment

Choose a reason for hiding this comment

jplehr commented Oct 31, 2024

jhuber6 commented Nov 7, 2024

jeanPerier commented Nov 8, 2024 • edited Loading

jeanPerier left a comment

Choose a reason for hiding this comment

Meinersbur commented Feb 13, 2025 • edited Loading

Meinersbur commented Feb 14, 2025

llvm-ci commented Feb 16, 2025

llvm-ci commented Feb 16, 2025

h-vetinari commented Feb 17, 2025

Meinersbur commented Sep 27, 2024 •

edited

Loading

github-actions bot commented Oct 1, 2024 •

edited

Loading

github-actions bot commented Oct 1, 2024 •

edited

Loading

Meinersbur commented Oct 1, 2024 •

edited

Loading

jeanPerier commented Nov 8, 2024 •

edited

Loading

Meinersbur commented Feb 13, 2025 •

edited

Loading