Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

masonry: make util pub to allow customizing buttons in an app #862

Merged
merged 1 commit into from
Feb 10, 2025

Conversation

eugenesvk
Copy link
Contributor

Similar to #861 this would help creating custom elements while relying on the already used/tested library utilities

@DJMcNab
Copy link
Member

DJMcNab commented Feb 10, 2025

What is the specific functionality you need access to from this module? I don't think that this module is designed to be public.

@DJMcNab DJMcNab requested a review from PoignardAzur February 10, 2025 09:51
@eugenesvk
Copy link
Contributor Author

I need the functions used in the Button Masonry widget (since I'm using that as a base) that are used in painting the button, specifically
use masonry::util::{fill_lin_gradient, stroke, UnitPoint};

@DJMcNab
Copy link
Member

DJMcNab commented Feb 10, 2025

I'll defer this to @PoignardAzur. To unblock you, I'd suggest just copying these items into your own crate, or even just hardcoding the gradient parameters.

I'd be interested in hearing your report on how implementing your own button type goes. My current expectation is that the way we support styling (in the sense of implementing design systems) would be to use custom implementations of widgets, so I'm hoping that goes well for you.

Could you either create a thread on Zulip when you have something to share?

Copy link
Contributor

@PoignardAzur PoignardAzur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is fine for now, though we'll probably remove that module eventually.

@DJMcNab DJMcNab added this pull request to the merge queue Feb 10, 2025
Merged via the queue into linebender:main with commit 25b12ad Feb 10, 2025
18 checks passed
@eugenesvk eugenesvk deleted the fr-pub-util branch February 10, 2025 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants