xilem: make a Pod method pub to allow creating custom buttons in an app #861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DJMcNab
reviewed
Feb 10, 2025
There was a problem hiding this comment.
Thanks! I'm looking forward to see what you create.
I do however think that all three of the methods in that impl block should be public. Would you be willing to do that in this PR?
If we're making something public, it's best practise to add documentation, even if it's just a small comment. E.g. for the method here:
- Create the Masonry widget for this view. In most cases, you will add the return value as a child to another Masonry widget, using a method on that widget type.
|
Sure, can make all pub, didn't add docs because I don't fully understand the various elements of the XilemView-on-top-of-MasonryWidget architecture, so please check the description |
|
Thank you! I've reworded some of the docs - my previous comment was written quickly, and reading it back revealed that it was misleading. |
DJMcNab
approved these changes
Feb 10, 2025
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 10, 2025
Similar to #861 this would help creating custom elements while relying on the already used/tested library utilities
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to create a custom button view, but when needing to pass to the masonry type could not convert the pod to a widgetpod.
So I'd like to make this method pub to allow that