Upscale Thumbnail is not work

[peter-gribanov]

Q	A
Branch?	1.0
Bug fix?	no
New feature?	no
BC breaks?	no
Deprecations?	no
Tests pass?	yes
Fixed tickets	-
License	MIT
Doc PR	-

allow_upscale is not work in Thumbnail filter #560

I propose to solve this problem by creating a separate filter #1015, because this filter is already very complex.

[lsmith77]

@antoligy / @robfrawley how do we want to deal with this .. 1.0 or 2.0 ?

[robfrawley]

Since it is a bug, we should likely fix it in both branches, IMHO.

[lsmith77]

right, I had a bit of a concern that this might be the sort of bug fix, that is a BC break in that people might be relying on the buggy behavior.

[robfrawley]

Ah, I see where you're coming from; I agree it could be considered a BC break and should therefore not be applied to 1.x.

With that said though, after reacquainting myself with #560 I actually don't believe we should do anything to fix the Thumbnail filter within this project; the issue actually lies in the imagine-library implementation. If we did want to resolve this, we should offer a PR to that library.

@lsmith77 Do you think we should work around imagine-library's internal handling ourselves instead? It seems kind of "hacky" to intentionally alter the behavior of our transformation library, but I guess it may be a solution if this is deemed an important "fix".

I think #1015 on the 2.x branch is the way to move forward.

[lsmith77]

would be better to try at least to work with upstream to get the bug fixed

[robfrawley]

@peter-gribanov Are you able to work on this with upstream avalanche123/Imagine?

[dbu]

has the upstream bug been fixed?

[peter-gribanov]

I think we can close this PR in favor #1015

[dbu]

cool!