-
Notifications
You must be signed in to change notification settings - Fork 379
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Filter] Add "fixed-size" filter implementation #1015
Conversation
@antoligy / @robfrawley how do we want to deal with this .. 1.0 or 2.0 ? |
My opinion is to have this as a new feature for our new 2.x major release. (Tagging as such now, but we can change back to 1.0 if others disagree) |
@peter-gribanov Please update/add to the RST documentation to include information about the new filter implementation you are introducing here. Reference the recent PR #941, which adds a resolution filter, for information on the expected additions and updates that need to be included in this PR. Note: While working on the RST docs, please be sure to test your changes and view the rendered output for correctness in a web browser of your choice. See the wiki entry for building the RST documentation for an overview of how to compile the RST files into HTML. Otherwise, everything else looks great! Thanks for the contribution. Shout out to @robbeman for the general filter implementation here. |
@robfrawley I added documentation about the filter. Maybe you want to add something. |
@robfrawley Thanks for the mention ❤️. (Yes, I'm that slow in noticing these things, hehe.) |
Any idea when this can be merged? |
@maximgubar thanks 👍 |
At the moment there is no way to create a fixed-size image.
This is a new filter that does this.
See #560 (comment) for more details.
Usage