Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Filter] Add "fixed-size" filter implementation #1015

Merged
merged 5 commits into from
Jul 23, 2018

Conversation

peter-gribanov
Copy link
Contributor

@peter-gribanov peter-gribanov commented Nov 28, 2017

Q A
Branch? 1.0
Bug fix? yes
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #560
License MIT
Doc PR -

At the moment there is no way to create a fixed-size image.
This is a new filter that does this.

See #560 (comment) for more details.

Usage

liip_imagine:
    filter_sets:
        my_thumb:
            filters:
                fixed: { width: 120, height: 90 }

@peter-gribanov peter-gribanov changed the title Create fixed size filter Create fixed-size filter Nov 28, 2017
@lsmith77
Copy link
Contributor

@antoligy / @robfrawley how do we want to deal with this .. 1.0 or 2.0 ?

@robfrawley
Copy link
Collaborator

My opinion is to have this as a new feature for our new 2.x major release. (Tagging as such now, but we can change back to 1.0 if others disagree)

@robfrawley robfrawley added this to the 2.0.0 milestone Jan 21, 2018
@robfrawley robfrawley added Level: New Feature 🆕 This item involves the introduction of new functionality. Type: Documentation This item pertains to documentation of this project. State: Confirmed This item has been confirmed by maintainers as legitimate. Type: Source Code This item pertains to the source code of this project. labels Jan 21, 2018
@robfrawley
Copy link
Collaborator

robfrawley commented Jan 21, 2018

@peter-gribanov Please update/add to the RST documentation to include information about the new filter implementation you are introducing here. Reference the recent PR #941, which adds a resolution filter, for information on the expected additions and updates that need to be included in this PR.

Note: While working on the RST docs, please be sure to test your changes and view the rendered output for correctness in a web browser of your choice. See the wiki entry for building the RST documentation for an overview of how to compile the RST files into HTML.

Otherwise, everything else looks great! Thanks for the contribution. Shout out to @robbeman for the general filter implementation here.

@peter-gribanov
Copy link
Contributor Author

@robfrawley I added documentation about the filter. Maybe you want to add something.

@robfrawley robfrawley changed the title Create fixed-size filter [Filter] Add "fixed-size" filter implementation Feb 16, 2018
@robbeman
Copy link

@robfrawley Thanks for the mention ❤️. (Yes, I'm that slow in noticing these things, hehe.)

@crabnky
Copy link

crabnky commented Jul 23, 2018

Any idea when this can be merged?

@maximgubar maximgubar merged commit d24e34c into liip:1.0 Jul 23, 2018
@peter-gribanov
Copy link
Contributor Author

@maximgubar thanks 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Level: New Feature 🆕 This item involves the introduction of new functionality. State: Confirmed This item has been confirmed by maintainers as legitimate. Type: Documentation This item pertains to documentation of this project. Type: Source Code This item pertains to the source code of this project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants