Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code improvements and fixes #72

Merged
merged 42 commits into from
Jan 20, 2025
Merged

Code improvements and fixes #72

merged 42 commits into from
Jan 20, 2025

Conversation

donosonaumczuk
Copy link
Member

No description provided.

@height Height
Copy link

height bot commented Jan 9, 2025

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

donosonaumczuk and others added 27 commits January 9, 2025 15:23
@donosonaumczuk
misc: compiler bump to 0.8.28 - pragma bump to ^0.8.26 - preparing fo…
6f7274f 
…r custom errors
@donosonaumczuk
misc: Custom Errors added on every revert case
f3e80a0
@vicnaum
misc: add fuzzing, via_ir and zkSync compilation to foundry.toml
f4f8751
@vicnaum
misc: commented out all lines that caused stack-too-deep
f435b95
@vicnaum
misc: Namespaces and Graph compile without IR
5873156
@vicnaum
misc: Rule Based Feed and Group made to compile without IR
706a0aa
@vicnaum
misc: RuleBasePrimitive made to compile without IR
0ba5dd1
@vicnaum
misc: Feed made to compile without IR
c5a740a
@vicnaum
misc: MigrationFeed made to compile without IR
af083d7
@vicnaum
misc: LensFactory made to compile without IR
0aad9f2
@vicnaum
misc: LensFactory tests made to compile without IR
cc4fe7e
@donosonaumczuk
Merge pull request #73 from lens-protocol/code-changes-compile-withou…
a157a84 
…t-viair

Merge `Code changes` with `Compile without viair`
@vicnaum
misc: Namespace code updated to give better revert reasons for non-ex…
cef1882 
…isting usernames
@vicnaum
test: coverage skipper added to deploy script
8198261
@vicnaum
test: coverage scripts added
e6ed308
@vicnaum
misc: added checks for address(0) to GraphCore
0da8a99
@vicnaum
fix: MigrationGraph fixed
20e2200
@vicnaum
fix: MigrationFeed extradata saving fix
283d303
@donosonaumczuk
misc: Better error throwing during enable/disable rule selectors
f4b42d5
@donosonaumczuk
misc: SkipTokenGate refactored to a more generic SkipGate permission
738c509
@donosonaumczuk
fix: Added missing _processEntityRulesChanges override on Feed and Graph
dfd8e4b
@donosonaumczuk
misc: getUsernameTokenId modifier from view to pure
a936313
@vicnaum
misc: add TippingPostAction to deployment script
df046e9
@vicnaum
fix: Post Rules events emitters added
fdbd1c7
@vicnaum
fix: Follow Rules events emitters added
1a5ce2a
@vicnaum
fix: editPost fixed (core call missing)
dd7919c
@vicnaum
misc: MigrationFeed changed to have forceChecks always
b862efd
donosonaumczuk and others added 13 commits January 16, 2025 15:47
@donosonaumczuk
fix: Rule processing main for-loop logic fixed - Call with empty para…
404b461 
…ms when processing params not present
@donosonaumczuk
misc: bool return from call renamed to callSucceeded for better code …
3984082 
…semantics
@donosonaumczuk
misc: IAccessControl incomplete natspec comment completed
036baf8
@donosonaumczuk
fix: Access Control verification function now calls with address(this…
a7dce24 
…) and 1 instad of address(0) and 0, to avoid reverting with invalid param
@donosonaumczuk
misc: Diff error constants and validations moved up on RoleBasedAcces…
3ce2ff1 
…sControl
@donosonaumczuk
misc: proxy__ prefix added to BeaconProxy functions
b1652f7
@vicnaum
fix: make all the rule-related hooks abstract and required to override
95176ad
@donosonaumczuk
feat: handledcall and handledsafecall added to CallLib
7395e05
@donosonaumczuk
fix: properly retrieve selector from ProxyAdmin call's calldata
a0bb896
@donosonaumczuk
fix: Use handled flavour for safecall and call when needed
96c48f6
@vicnaum
misc: processRemovePost renamed to processDeletePost
f458e57
@vicnaum
misc: _handleCall changed to pure
f0128a6
@vicnaum
misc: Renames Self() error to ActionOnSelf() to prevent clashing with…
d93a72f 
… Rust reserved keyword
@joshstevens19 joshstevens19 marked this pull request as ready for review January 20, 2025 12:55
@joshstevens19 joshstevens19 merged commit faf3765 into development Jan 20, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@donosonaumczuk @joshstevens19 @vicnaum