Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge Code changes with Compile without viair #73

Merged
merged 9 commits into from
Jan 10, 2025

Conversation

vicnaum
Copy link
Collaborator

@vicnaum vicnaum commented Jan 10, 2025

This PR removes IR optimizations to fix compilation issues. Changes include:

  • Removed IR optimizations from foundry.toml
  • Fixed stack-too-deep errors in various contracts
  • Modified contracts to compile without IR:
    • LensFactory and tests
    • MigrationFeed
    • Feed
    • RuleBasePrimitive
    • RuleBasedFeed and Group
    • Namespaces and Graph

The changes maintain functionality while ensuring stable compilation.

Copy link

height bot commented Jan 10, 2025

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

@donosonaumczuk donosonaumczuk merged commit a157a84 into code-changes Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants