Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update plot recipe for simple_calibration report #31

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

fhagemann
Copy link
Contributor

Closes #30.

I propose renaming the field fep_guess to peak_guess (we had a similar thing with LQ where the current tagged version does not match the naming on main). I would then propose to release LegendMakie@0.1.0 with a new minor version of LegendSpecFits@0.4.0 where this change is incorporated.

@fhagemann fhagemann requested a review from LisaSchlueter March 8, 2025 22:19
@fhagemann fhagemann self-assigned this Mar 8, 2025
@fhagemann
Copy link
Contributor Author

Tests will fail until legend-exp/LegendSpecFits.jl#108 is merged, so let's wait for that first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

plot recipe: simple_calibration
1 participant