Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

plot recipe: simple_calibration #30

Open
LisaSchlueter opened this issue Mar 7, 2025 · 0 comments · May be fixed by #31
Open

plot recipe: simple_calibration #30

LisaSchlueter opened this issue Mar 7, 2025 · 0 comments · May be fixed by #31
Assignees
@fhagemann

Comments

@LisaSchlueter
Copy link

This concerns the plot recipe for the simple_calibration report (LegendSpecFits).
With the (not yet merged) PR legend-exp/LegendSpecFits.jl#108 , a field in the report will be renamed :fep_guess --> :peak_guess.
This has to be accounted for in the plot recipe:

  • change fieldname (or new recipe?)
  • value of fep_guess is hardcoded in current recipe for cal == true ---> peak_guess = ustrip(report.c * report.peak_guess) (see PR 108)
  • binning and axis limits are also hardcoded. Optional argument?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fhagemann fhagemann

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update plot recipe for simple_calibration report legend-exp/LegendMakie.jl
2 participants
@fhagemann @LisaSchlueter