Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: stx and sip10 transaction error routing #3595

Merged
merged 1 commit into from
Apr 24, 2023
Merged

fix: stx and sip10 transaction error routing #3595

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/app/pages/send/send-crypto-asset-form/send-crypto-asset-form.routes.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ const recipientAccountsDrawerRoute = (

const editNonceDrawerRoute = <Route path={RouteUrls.EditNonce} element={<EditNonceDrawer />} />;
const broadcastErrorDrawerRoute = (
<Route path={RouteUrls.TransactionBroadcastError} element={<BroadcastErrorDrawer />} />
<Route path={'confirm/broadcast-error'} element={<BroadcastErrorDrawer />} />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't worked with the send form in awhile and know you have made a lot of changes, but are you sure {broadcastErrorDrawerRoute} just doesn't need to be moved and nested in the confirm route here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried to do so, but the flow still ends up with error. seems there is problem with sip10/stx routes conflicts bc I added contractId param in sip10 routes

);

export const sendCryptoAssetFormRoutes = (
Expand Down