fix: stx and sip10 transaction error routing #3595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fbwoolf
reviewed
Apr 24, 2023
| @@ -32,7 +32,7 @@ const recipientAccountsDrawerRoute = ( | |||
|
|
|||
| const editNonceDrawerRoute = <Route path={RouteUrls.EditNonce} element={<EditNonceDrawer />} />; | |||
| const broadcastErrorDrawerRoute = ( | |||
| <Route path={RouteUrls.TransactionBroadcastError} element={<BroadcastErrorDrawer />} /> | |||
| <Route path={'confirm/broadcast-error'} element={<BroadcastErrorDrawer />} /> | |||
There was a problem hiding this comment.
I haven't worked with the send form in awhile and know you have made a lot of changes, but are you sure {broadcastErrorDrawerRoute} just doesn't need to be moved and nested in the confirm route here?
There was a problem hiding this comment.
I tried to do so, but the flow still ends up with error. seems there is problem with sip10/stx routes conflicts bc I added contractId param in sip10 routes
fbwoolf
approved these changes
Apr 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See title