-
Notifications
You must be signed in to change notification settings - Fork 40.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removes 'rwx' permissions for global users #54581
Removes 'rwx' permissions for global users #54581
Conversation
@bsnchan: Adding do-not-merge/release-note-label-needed because the release note process has not been followed. One of the following labels is required "release-note", "release-note-action-required", or "release-note-none". Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Hi @bsnchan. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://github.com/kubernetes/kubernetes/wiki/CLA-FAQ to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/assign @rmmh I've signed the CLA - let me know if you need anything else. Thanks in advance! |
/ok-to-test |
- the tests make an assumption that the permissions on the /tmp dir have not been altered
5951197
to
d7768e6
Compare
Hi. @dims is there anything we can help with to get this PR merged? |
@gregpatricio you need approval/lgtm from @saad-ali and @rmmh . probably best to ping them on sig-storage channel. Or check the OWNERS file above to see if there are others you can try to get reviews from. |
/sig storage |
cc @kubernetes/sig-storage-pr-reviews |
/lgtm |
/test pull-kubernetes-bazel-test |
Hi @saad-ali, It looks like one of the tests were flakey so I had to rerun the pull-kubernetes-bazel-test. Looks like all this PR needs is the approved label. |
/approve no-issue |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bsnchan, saad-ali Associated issue requirement bypassed by: saad-ali The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
/test all [submit-queue is verifying that this PR is safe to merge] |
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here. |
/cc @jpbetz re: cherry pick for 1.8 conformance |
@jpbetz - any chance we can get this cherry picked in for 1.8.6? |
been altered
Signed-off-by: Brenda Chan brchan@pivotal.io
What this PR does / why we need it:
This PR modifies a conformance test that checks the file permissions when the
/tmp
dir is mounted.The current tests make an assumption that the permissions on the
/tmp
dir on the host system has not been altered. We removed the check that global users needrwx
, so the tests now only check fordtrwxrwx
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close that issue when PR gets merged): N/ASpecial notes for your reviewer: N/A
Release note: