Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conformance results from v1.8/cfcr #63

Merged
merged 5 commits into from
Nov 13, 2017

Conversation

bsnchan
Copy link
Contributor

@bsnchan bsnchan commented Nov 7, 2017

vendor: Cloud Foundry
name: Cloud Foundry Container Runtime
version: v0.8.0
website_url: https://www.cloudfoundry.org/container-runtime/
documentation_url: https://docs-kubo.cfapps.io/
product_logo_url: https://www.cloudfoundry.org/wp-content/uploads/2017/10/CFF-Container-Runtime-Full-Color-768x230.png

Manifaust and others added 2 commits November 6, 2017 18:02
[#152479548]

Signed-off-by: Brenda Chan <brchan@pivotal.io>
version.txt is no longer needed as it's plugged directly into the
e2e.log file: cncf#55
@bsnchan
Copy link
Contributor Author

bsnchan commented Nov 7, 2017

There is one test that is failing but should be resolved by kubernetes/kubernetes#54581

Current failing test:

Nov  8 13:07:17.234: INFO: Unexpected error occurred: expected "mode of file \"/test-volume\": dtrwxrwxrwx" in container output: Expected
    <string>: mount type of "/test-volume": 61267
    mode of file "/test-volume": dtrwxrwx---

to contain substring
    <string>: mode of file "/test-volume": dtrwxrwxrwx

[#152479548]

Signed-off-by: Iain Sproat <isproat@pivotal.io>
@WilliamDenniss
Copy link
Member

WilliamDenniss commented Nov 8, 2017

Thanks for fixing that issue, looks like it was just merged (tracking in #27). If we assume the test will pass with that fix for now, can you commit to updating your conformance results once the fix is available in the e2e test image?

@bsnchan
Copy link
Contributor Author

bsnchan commented Nov 8, 2017

Thanks @WilliamDenniss - Would it be possible to still get the k8s certification even with this one failure? We will definitely update our test results once the e2e test image has be updated.

Let us know if there is anything we can do to bump the e2e test image.

tests

[#152479548]

Signed-off-by: Brenda Chan <brchan@pivotal.io>
@WilliamDenniss
Copy link
Member

+1 from my perspective, since you have proactively fixed the issue and I assume tested that you're now passing. Be aware that if the test still fails after the fix is merged, you could be decertified but I trust that you will re-test and verify that.

@bgrant0607
Copy link

Looks like a test bug, so I'm fine with excluding it until it is fixed.

@chipchilders
Copy link

@kbarnard10 CFF has signed the participation form now

@kbarnard10
Copy link
Contributor

@bsnchan Looks like your version.txt file is missing. Can you add?

@bsnchan
Copy link
Contributor Author

bsnchan commented Nov 9, 2017

Hi @kbarnard10 - Sorry about that. We assumed that the because of issue mentioned here that the version can be extracted from the e2e.log.

I've updated the PR with the test a new test run and a version.txt. Please let me know if you need anything else.

@kbarnard10
Copy link
Contributor

+1

@kbarnard10 kbarnard10 merged commit a881968 into cncf:master Nov 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants