Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📖 Update guidelines for runtime hook implementation #10449

Merged
merged 1 commit into from
Apr 17, 2024

Conversation

pravarag
Copy link
Contributor

What this PR does / why we need it:
Updates guidelines for runtime hook implementation
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #7812

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 17, 2024
@k8s-ci-robot k8s-ci-robot added do-not-merge/needs-area PR is missing an area label size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 17, 2024
@chrischdi
Copy link
Member

/retitle 📖 Update guidelines for runtime hook implementation

@k8s-ci-robot k8s-ci-robot changed the title Update guidelines for runtime hook implementation 📖 Update guidelines for runtime hook implementation Apr 17, 2024
@chrischdi
Copy link
Member

/area documentation

@k8s-ci-robot k8s-ci-robot added area/documentation Issues or PRs related to documentation and removed do-not-merge/needs-area PR is missing an area label labels Apr 17, 2024
@pravarag pravarag force-pushed the update-runtime-hook branch from bd3db7a to d02cf9f Compare April 17, 2024 12:44
@pravarag pravarag force-pushed the update-runtime-hook branch from d02cf9f to 675eae5 Compare April 17, 2024 13:09
@sbueringer
Copy link
Member

Thx

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 17, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 7649f84505ef72b87c054c448c4ff9339e159344

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 17, 2024
@k8s-ci-robot k8s-ci-robot merged commit 09649d6 into kubernetes-sigs:main Apr 17, 2024
18 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.8 milestone Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/documentation Issues or PRs related to documentation cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Runtime Hook implementation guideline is not quite clear
4 participants