-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Runtime Hook implementation guideline is not quite clear #7812
Comments
/triage accepted Also FYI, we recently made it possible to use runtime extensions with tilt, so you can quickly iterate changes, debug live etc. The process is the same as developing a provider with tilt (https://cluster-api.sigs.k8s.io/developer/tilt.html#available-providers), but this is another thing that we should probably surface better in our doc /remove-kind bug |
/help |
@fabriziopandini: GuidelinesPlease ensure that the issue body includes answers to the following questions:
For more details on the requirements of such an issue, please see here and ensure that they are met. If this request no longer meets these requirements, the label can be removed In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/priority important-soon |
This issue is labeled with You can:
For more details on the triage process, see https://www.kubernetes.dev/docs/guide/issue-triage/ /remove-triage accepted |
I just checked the documentation and we have https://cluster-api.sigs.k8s.io/tasks/experimental-features/runtime-sdk/implement-extensions.html#extensionconfig to highlight the fact that an ExtensionConfig is required But ok to add a reminder at the beginning of Tips & tricks, something like
/triage accepted |
/good-first-issue |
@fabriziopandini: GuidelinesPlease ensure that the issue body includes answers to the following questions:
For more details on the requirements of such an issue, please see here and ensure that they are met. If this request no longer meets these requirements, the label can be removed In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign |
@fabriziopandini I've raised a PR for this minor change as suggested above. |
What steps did you take and what happened:
I've followed the Implementation guideline for
Runtime Hooks
to implement a first version of an own hook.The current documentation refers to the
test/extension
directory for a full exampleI've discovered all the manifests under
config/default
immediately and got something running in a very early state.Also the
kubectl create --raw ...
commands from tips&tricks worked fine.But it took me a while to understand that i missed to deploy an
ExtensionConfig
(extensionconfig.yaml
fromtest/extension
directory).What did you expect to happen:
A more clear guidance how to implement an own runtime hook.
Anything else you would like to add:
the RFC contains some notes about the
ExtensionConfig
(https://github.com/kubernetes-sigs/cluster-api/blob/main/docs/proposals/20220221-runtime-SDK.md#registering-runtime-extensions)Not sure if it's worth the effort, but something to start from scratch by running some
make targets
(kubebuilder
) commands to have everything generated for a new hook would be ❤️Environment:
kubectl version
):/etc/os-release
):/kind bug
The text was updated successfully, but these errors were encountered: