Skip to content
This repository has been archived by the owner on Aug 17, 2023. It is now read-only.

Add PatrickXYS into reviewer #382

Merged
merged 1 commit into from
Jul 28, 2020
Merged

Add PatrickXYS into reviewer #382

merged 1 commit into from
Jul 28, 2020

Conversation

PatrickXYS
Copy link
Member

Hi all, I have continuously contributed to kubeflow/kfctl repo and excited to continue working on it.

Thus, I want to add myself into reviewer list to help kfctl grow fast.

The list of my PR on kfctl:

#380
#357
#282
#273

@kubeflow-bot
Copy link

This change is Reviewable

@PatrickXYS
Copy link
Member Author

@PatrickXYS PatrickXYS changed the title Add myself into reviewer Add PatrickXYS into reviewer Jul 25, 2020
@crobby
Copy link
Member

crobby commented Jul 28, 2020

/approve
Welcome aboard

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: crobby

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@PatrickXYS
Copy link
Member Author

@crobby Thanks!

If you don't mind, can you /lgtm?

@crobby
Copy link
Member

crobby commented Jul 28, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot merged commit e7f548d into kubeflow:master Jul 28, 2020
@PatrickXYS PatrickXYS deleted the add_user branch July 28, 2020 18:05
crobby pushed a commit to crobby/kfctl that referenced this pull request Feb 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants