-
Notifications
You must be signed in to change notification settings - Fork 137
Find User Default Region and Cred Setting #282
Conversation
Hi @PatrickXYS. Thanks for your PR. I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign @Jeffwan |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to change your implementation
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Jeffwan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Issue to solve
The issue is found in the kubeflow repo here, the situation is that user use
kfctl apply kfctl_aws.yaml
can't find their plugin default settings.Changes we make
Rewrite
IsEksCluster
function to take default plugin settings without settingAWS_REGION
manually.This change is