Skip to content
This repository has been archived by the owner on Aug 17, 2023. It is now read-only.

Find User Default Region and Cred Setting #282

Merged
merged 1 commit into from
Mar 20, 2020
Merged

Find User Default Region and Cred Setting #282

merged 1 commit into from
Mar 20, 2020

Conversation

PatrickXYS
Copy link
Member

@PatrickXYS PatrickXYS commented Mar 17, 2020

Issue to solve

The issue is found in the kubeflow repo here, the situation is that user use kfctl apply kfctl_aws.yaml can't find their plugin default settings.

Changes we make

Rewrite IsEksCluster function to take default plugin settings without setting AWS_REGION manually.


This change is Reviewable

@k8s-ci-robot
Copy link
Contributor

Hi @PatrickXYS. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@PatrickXYS
Copy link
Member Author

/assign @Jeffwan

Copy link
Member

@Jeffwan Jeffwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to change your implementation

@PatrickXYS PatrickXYS requested a review from Jeffwan March 17, 2020 22:14
@Jeffwan
Copy link
Member

Jeffwan commented Mar 20, 2020

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Jeffwan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants