Skip to content
This repository has been archived by the owner on Aug 17, 2023. It is now read-only.

Add Support for AWS Dex Basic-Authentication #357

Merged
merged 1 commit into from
Jun 23, 2020
Merged

Add Support for AWS Dex Basic-Authentication #357

merged 1 commit into from
Jun 23, 2020

Conversation

PatrickXYS
Copy link
Member

Which issue is resolved by this Pull Request:
Resolves #328

Description of your changes:
Integrated Dex as basic authentication option in AWS Kubeflow.

@kubeflow-bot
Copy link

This change is Reviewable

@k8s-ci-robot k8s-ci-robot requested review from adrian555 and Tomcli June 22, 2020 18:19
@PatrickXYS
Copy link
Member Author

/assign @Jeffwan

Jeffwan
Jeffwan reviewed Jun 22, 2020
View reviewed changes
pkg/kfapp/aws/aws.go Outdated
@@ -483,13 +421,19 @@ func (aws *Aws) Generate(resources kftypes.ResourceEnum) error {
return errors.WithStack(err)
}

// TODO: AWS doesn't enable BasicAuth yet.
if aws.kfDef.Spec.UseBasicAuth {
if pluginSpec.GetEnableBasicAuth() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

em.. I am thinking if we should think it's basic auth or equivalent as coginito and oidc.
Technically, I think they are same. However, it's kind of a simple auth without extra AWS services.

@PatrickXYS
Copy link
Member Author

Made two changes:

  1. Remove "enableBasicAuth"
  2. Encrypt password in Kfctl.

Tested locally and it works

Jeffwan
Jeffwan suggested changes Jun 23, 2020
View reviewed changes
@Jeffwan
Copy link
Member

Jeffwan commented Jun 23, 2020

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Jeffwan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@PatrickXYS
Copy link
Member Author

/test kubeflow-kfctl-presubmit

@Jeffwan
Copy link
Member

Jeffwan commented Jun 23, 2020

Seems the test pass successfully.
http://testing-argo.kubeflow.org/workflows/kubeflow-test-infra/kubeflow-kfctl-presubmit-unittests-357-a8d992e-0658-93e9?tab=workflow

@Jeffwan
Copy link
Member

Jeffwan commented Jun 23, 2020

/test kubeflow-kfctl-presubmit

@PatrickXYS
Copy link
Member Author

@Jeffwan Should I rebase your change #359?

@Jeffwan
Copy link
Member

Jeffwan commented Jun 23, 2020

@PatrickXYS I don't this so. These are unrelated.

@PatrickXYS
Copy link
Member Author

/retest

@k8s-ci-robot k8s-ci-robot removed the lgtm label Jun 23, 2020
@PatrickXYS
Copy link
Member Author

@Jeffwan Not sure why the tests keep failing, I tried to rebase changes and see if it succeed.

@Jeffwan
Copy link
Member

Jeffwan commented Jun 23, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot merged commit 074b580 into kubeflow:master Jun 23, 2020
Jeffwan added a commit to Jeffwan/kfctl that referenced this pull request Jun 29, 2020
@Jeffwan
Add Support for AWS Dex Basic-Authentication (kubeflow#357)
5e38439
Jeffwan added a commit to Jeffwan/kfctl that referenced this pull request Jun 29, 2020
@Jeffwan
Add Support for AWS Dex Basic-Authentication (kubeflow#357)
cb5301b
k8s-ci-robot pushed a commit that referenced this pull request Jun 29, 2020
@Jeffwan
Cherry pick #357 #359 #362 to v1.1-branch (#363)
133dd3b 
* Add region into IRSA role name (#359)

* Add Support for AWS Dex Basic-Authentication (#357)

* Pretty print log messages IAM policy(from #327) (#362)
vpavlin pushed a commit to vpavlin/kfctl that referenced this pull request Jul 10, 2020
@vpavlin
Add Support for AWS Dex Basic-Authentication (kubeflow#357)
74bba39
vpavlin pushed a commit to vpavlin/kfctl that referenced this pull request Jul 20, 2020
@vpavlin
Add Support for AWS Dex Basic-Authentication (kubeflow#357)
4e04afe
vpavlin pushed a commit to vpavlin/kfctl that referenced this pull request Jul 22, 2020
@vpavlin
Add Support for AWS Dex Basic-Authentication (kubeflow#357)
4c42c35
vpavlin pushed a commit to vpavlin/kfctl that referenced this pull request Jul 22, 2020
@vpavlin
Add Support for AWS Dex Basic-Authentication (kubeflow#357)
f02e3d4
@PatrickXYS PatrickXYS mentioned this pull request Jul 25, 2020
Merged
crobby pushed a commit to crobby/kfctl that referenced this pull request Feb 25, 2021
Add Support for AWS Dex Basic-Authentication (kubeflow#357)
254bb80
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Jeffwan Jeffwan Jeffwan approved these changes

@adrian555 adrian555 Awaiting requested review from adrian555

@Tomcli Tomcli Awaiting requested review from Tomcli

Assignees

@Jeffwan Jeffwan

Labels
approved lgtm size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Orchestrate dex for kfctl_aws manifest
4 participants
@PatrickXYS @kubeflow-bot @Jeffwan @k8s-ci-robot