Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tech Debt: Turn on no implicit any rule in tsconfig #403

Merged
merged 2 commits into from
Sep 15, 2022

Conversation

ibolton336
Copy link
Member

No description provided.

@gildub
Copy link
Contributor

gildub commented Sep 15, 2022

Helps with #408

Copy link
Contributor

@gildub gildub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gildub gildub merged commit cee0600 into konveyor:main Sep 15, 2022
@mturley
Copy link
Collaborator

mturley commented Sep 15, 2022

Nice!

@ibolton336
Copy link
Member Author

Nice!

@mturley Need to go back through and add more TS support. Maybe just removing any references of 'any' is a good start as you suggested?

@mturley
Copy link
Collaborator

mturley commented Sep 15, 2022

@ibolton336 I think yes, but in doing so we may identify places where it's not as easy as simply replacing the any with another simple type. We might find things unfolding from that that we want to open separate issues for, etc. But yeah, maybe a PR for any obvious types we can substitute in would be good. There might also be places where we can rely on type inference instead of an explicit type, though. hovering things to see what VS Code thinks the types are might give hints there. In some places we might want to introduce generics.

If you guys are starting on that, if you don't mind can you exclude proxy-form.tsx and identity-form.tsx to avoid conflicts with #404? There may be a couple other small places where I've messed with types as well (client/src/app/utils/utils.ts for example).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants