No implicit any (#403)

Co-authored-by: Gilles Dubreuil <gilles@redhat.com>

client/src/app/Constants.ts

@@ -21,7 +21,7 @@ export interface IEnvVars {
   KEYCLOAK_SERVER_URL: string;
   UI_INGRESS_PROXY_BODY_SIZE: string;
 }
-export const ENV: IEnvVars = window["_env"] || {};
+export const ENV: IEnvVars = (window as { [key: string]: any })["_env"] || {};
 export const isAuthRequired = ENV.AUTH_REQUIRED !== "false";
 export const uploadLimit = ENV.UI_INGRESS_PROXY_BODY_SIZE || "500m";
 

client/src/app/api/rest.tsx

@@ -87,7 +87,11 @@ const buildQuery = (params: any) => {
 
 //Volumes
 // poll clean task
-export const getTaskById = ({ queryKey }): AxiosPromise<Task> => {
+export const getTaskById = ({
+  queryKey,
+}: {
+  queryKey: any;
+}): AxiosPromise<Task> => {
   const [_, processId] = queryKey;
   return axios.get<Task>(`${TASKS}/${processId}`);
 };

client/src/app/pages/applications/analysis-wizard/components/add-custom-rules.tsx

@@ -168,7 +168,11 @@ export const AddCustomRules: React.FunctionComponent<IAddCustomRules> = ({
     setReadFileData((prevReadFiles) => [...prevReadFiles, newFile]);
   };
 
-  const handleReadFail = (error: DOMException, percentage, file: File) => {
+  const handleReadFail = (
+    error: DOMException,
+    percentage: number,
+    file: File
+  ) => {
     setError(error.toString());
     setReadFileData((prevReadFiles) => [
       ...prevReadFiles,
@@ -186,13 +190,13 @@ export const AddCustomRules: React.FunctionComponent<IAddCustomRules> = ({
     (fileData) => fileData.loadResult === "success"
   ).length;
 
-  const getloadPercentage = (filename) => {
+  const getloadPercentage = (filename: string) => {
     const readFile = readFileData.find((file) => file.fileName === filename);
     if (readFile) return readFile.loadPercentage;
     return 0;
   };
 
-  const getloadResult = (filename) => {
+  const getloadResult = (filename: string) => {
     const readFile = readFileData.find((file) => file.fileName === filename);
     if (readFile) return readFile.loadResult;
     return undefined;

client/src/app/pages/applications/components/application-form/__tests__/application-form.test.tsx

@@ -21,7 +21,7 @@ import "@testing-library/jest-dom";
 import { BusinessService } from "@app/api/models";
 
 jest.mock("react-i18next");
-const data = [];
+const data: any[] = [];
 mock.onGet(`${BUSINESS_SERVICES}`).reply(200, data);
 mock.onGet(`${TAG_TYPES}`).reply(200, data);
 mock.onGet(`${APPLICATIONS}`).reply(200, data);

client/src/app/pages/applications/components/application-form/application-form.tsx

@@ -195,7 +195,7 @@ export const ApplicationForm: React.FC<ApplicationFormProps> = ({
     let standardUrlRegex =
       /(https?:\/\/(?:www\.|(?!www))[a-zA-Z0-9][a-zA-Z0-9-]+[a-zA-Z0-9]\.[^\s]{2,}|www\.[a-zA-Z0-9][a-zA-Z0-9-]+[a-zA-Z0-9]\.[^\s]{2,}|https?:\/\/(?:www\.|(?!www))[a-zA-Z0-9]+\.[^\s]{2,}|www\.[a-zA-Z0-9]+\.[^\s]{2,})/gi;
     standardUrlRegex = new RegExp(standardUrlRegex);
-    const containsURL = (string) =>
+    const containsURL = (string: string) =>
       gitUrlRegex.test(string) || standardUrlRegex.test(string);
 
     return schema.test("gitUrlTest", "Must be a valid URL.", (value) => {

client/src/app/pages/identities/components/identity-form/__tests__/identity-form.test.tsx

@@ -17,7 +17,7 @@ import "@testing-library/jest-dom";
 
 jest.mock("react-i18next");
 
-const data = [];
+const data: any[] = [];
 
 mock.onGet(`${IDENTITIES}`).reply(200, data);
 

client/src/app/queries/applications.ts

@@ -37,7 +37,7 @@ export const useFetchApplications = () => {
       onSuccess: (data: Application[]) => {
         queryClient.invalidateQueries(reviewsQueryKey);
       },
-      onError: (err: AxiosError) => console.log(error),
+      onError: (error: AxiosError) => console.log(error),
     }
   );
   return {

client/src/app/queries/assessments.ts

@@ -33,7 +33,7 @@ export const useFetchApplicationAssessments = (
         const allAssessmentsForApp = response.data;
         return allAssessmentsForApp[0];
       },
-      onError: (error) => console.log("error, ", error),
+      onError: (error: any) => console.log("error, ", error),
     }))
   );
   const queryResultsByAppId: Record<number, UseQueryResult<Assessment>> = {};

client/src/app/queries/imports.ts

@@ -18,7 +18,7 @@ export const useFetchImports = (
   const { data, isLoading, error, refetch } = useQuery(
     [ImportsQueryKey, importSummaryID, isValid],
     () => getApplicationImports(importSummaryID, isValid),
-    { onError: (err: Error) => console.log(error) }
+    { onError: (error) => console.log(error) }
   );
   return {
     imports: data || [],
@@ -34,7 +34,7 @@ export const useFetchImportSummaries = () => {
     getApplicationsImportSummary,
     {
       refetchInterval: 5000,
-      onError: (err: Error) => console.log(error),
+      onError: (error) => console.log(error),
     }
   );
   return {
@@ -49,7 +49,7 @@ export const useFetchImportSummaryByID = (id: number | string) => {
   const { data, isLoading, error, refetch } = useQuery(
     [ImportQueryKey, id],
     () => getApplicationImportSummaryById(id),
-    { onError: (err: Error) => console.log(error) }
+    { onError: (error) => console.log(error) }
   );
 
   return {

client/src/app/queries/proxies.ts

@@ -27,7 +27,7 @@ export const useFetchProxies = (
   const { isLoading, data, error } = useQuery(
     "proxies",
     async () => (await getProxies()).data,
-    { onError: () => console.log("error, ", error) }
+    { onError: (error) => console.log("error, ", error) }
   );
   return {
     proxies: data || [],

client/src/app/queries/volumes.ts

@@ -29,7 +29,13 @@ export const useFetchVolumes = (): IVolumeFetchState => {
   };
 };
 
-export const useCleanRepositoryMutation = ({ onSuccess, onError }) => {
+export const useCleanRepositoryMutation = ({
+  onSuccess,
+  onError,
+}: {
+  onSuccess: any;
+  onError: any;
+}) => {
   // Mutation to kick off the clean task
   const {
     data: mutationResult,

client/src/app/test-config/__mocks__/react-i18next.ts

@@ -0,0 +1,12 @@
+export const useTranslation = () => {
+  return {
+    t: (str: any) => str,
+    i18n: {
+      changeLanguage: () => new Promise(() => {}),
+    },
+  };
+};
+export const initReactI18next = {
+  type: "3rdParty",
+  init: jest.fn(),
+};

client/src/app/utils/utils.ts

@@ -77,7 +77,7 @@ export const duplicateNameCheck = <T extends { name?: string }>(
   nameValue: T["name"]
 ) => duplicateFieldCheck("name", itemList, currentItem, nameValue);
 
-export const dedupeFunction = (arr) =>
+export const dedupeFunction = (arr: any[]) =>
   arr?.filter(
     (value, index, self) =>
       index === self.findIndex((t) => t.value === value.value)

client/tsconfig.json

@@ -2,12 +2,8 @@
   "include": ["src/**/*"],
   "compilerOptions": {
     "outDir": "dist",
-    "target": "es5",  
-    "lib": [
-      "dom",
-      "dom.iterable",
-      "esnext"
-    ],
+    "target": "es5",
+    "lib": ["dom", "dom.iterable", "esnext"],
     "sourceMap": true,
     "allowJs": true,
     "checkJs": true,
@@ -21,7 +17,7 @@
     "moduleResolution": "node",
     "resolveJsonModule": true,
     "isolatedModules": true,
-    "noImplicitAny": false,
+    "noImplicitAny": true,
     "forceConsistentCasingInFileNames": true,
     "baseUrl": ".",
     "paths": {
@@ -36,6 +32,6 @@
     "noFallthroughCasesInSwitch": true,
     "noImplicitThis": true,
     "strictNullChecks": true,
-    "noEmit": true 
-  },
+    "noEmit": true
+  }
 }