Persist lastFetched control data across launcher restarts #990
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the first iteration of persisting last fetched data.
RebeccaMahany
previously approved these changes
Jan 31, 2023
directionless
previously approved these changes
Jan 31, 2023
seejdev
dismissed stale reviews from directionless and RebeccaMahany
via
6ecb89e
directionless
approved these changes
Feb 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #979
Enables the control service to persist its in-memory cache of control data to disk, so it can be persisted across launcher restarts. The control service will retrieve subsystem hashes from the key/value store if it doesn't have an in-memory cache record for that subsystem.
I also took the opportunity to move the key/value store interfaces to
pkg/agentand tried to making the naming scheme more succinct.