Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve control server fetching to persist lastFetched data through restarts #979

Closed
seejdev opened this issue Dec 23, 2022 · 0 comments · Fixed by #990
Closed

Improve control server fetching to persist lastFetched data through restarts #979

seejdev opened this issue Dec 23, 2022 · 0 comments · Fixed by #990
Assignees

Comments

@seejdev
Copy link
Contributor

seejdev commented Dec 23, 2022

#966 introduces launcher's ability to fetch control server data. The update data is cached in-memory, which avoids re-fetching updates which have already been applied.

If launcher is restarted, the in-memory cache is lost and all update data will be re-fetched and re-applied. Before enabling control server features at scale, we should enable launcher to record and persist update data to disk, and reload them into the in-memory cache after restarts so we can avoid the unnecessary K2 requests involved in re-fetching.

Relates to #935

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant