Default to x-www-browser over xdg-open for handling menu actions #1214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RebeccaMahany
force-pushed
the
becca/consistent-browser-open-linux
branch
from
f6577ee to
2fc2032
Compare
James-Pickett
previously approved these changes
May 31, 2023
seejdev
approved these changes
Jun 1, 2023
|
Don't think we need this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates
action_open_url_linuxto use same logic as notifications do for opening URLs: https://github.com/kolide/launcher/blob/main/ee/desktop/user/notify/notify_linux.goSee #1065 PR description for more details.
For whatever reason, I'm seeing different behavior in test than with notifications -- xdg-open does a better job here than x-www-browser does.