-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support notification actions for Ubuntu 22.04/Wayland #1065
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
directionless
previously approved these changes
Mar 3, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems okay. Though the labels imply there's some refactoring that might help.
seejdev
previously approved these changes
Mar 3, 2023
directionless
requested changes
Mar 3, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks solid. But please put ctx
first
directionless
approved these changes
Mar 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When testing notification actions previously, @James-Pickett noticed that on his Linux laptop, notification actions would open the URL in a text editor instead of using the default browser. After more investigation, this issue appears to be present on Ubuntu 22.04, but not on the 22.04 VMs I have. My initial guess was that James's laptop uses Wayland and all of the VMs (accessed via VNC or RDP) are x11, but it could be some other difference between his environment and my VMs that causes the issue.
Fixes:
DISPLAY
for Wayland sessions as well. We cannot pull this from loginctl like we do for x11 sessions, so ultimately we look for the xwayland process, knowing that the display is the first command-line argument to this process. It's possibly a little brittle, but I couldn't find a better option.XDG_DATA_DIRS
. If the user has installed their browsers only via snap (e.g. Firefox, even when installed via apt, actually installs via snap), then the mimeinfo defaults are stored in this separate directory that xdg-open cannot find, ultimately resulting in the behavior noted where the URL is opened in a text editor.