Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support notification actions for Ubuntu 22.04/Wayland #1065

Merged
merged 14 commits into from
Mar 3, 2023

Conversation

RebeccaMahany
Copy link
Contributor

@RebeccaMahany RebeccaMahany commented Mar 1, 2023

When testing notification actions previously, @James-Pickett noticed that on his Linux laptop, notification actions would open the URL in a text editor instead of using the default browser. After more investigation, this issue appears to be present on Ubuntu 22.04, but not on the 22.04 VMs I have. My initial guess was that James's laptop uses Wayland and all of the VMs (accessed via VNC or RDP) are x11, but it could be some other difference between his environment and my VMs that causes the issue.

Fixes:

  • First, default to x-www-browser over xdg-open, since x-www-browser does not appear to have the issue noted below figuring out what application to use to open the URL.
  • Second, set DISPLAY for Wayland sessions as well. We cannot pull this from loginctl like we do for x11 sessions, so ultimately we look for the xwayland process, knowing that the display is the first command-line argument to this process. It's possibly a little brittle, but I couldn't find a better option.
  • Finally, add the snapd directory where mimeinfo.cache lives to XDG_DATA_DIRS. If the user has installed their browsers only via snap (e.g. Firefox, even when installed via apt, actually installs via snap), then the mimeinfo defaults are stored in this separate directory that xdg-open cannot find, ultimately resulting in the behavior noted where the URL is opened in a text editor.

@RebeccaMahany RebeccaMahany changed the title Draft: Fix notification actions for Wayland Support notification actions for Ubuntu 22.04/Wayland Mar 3, 2023
@RebeccaMahany RebeccaMahany marked this pull request as ready for review March 3, 2023 15:27
@RebeccaMahany RebeccaMahany changed the title Support notification actions for Ubuntu 22.04/Wayland Support notification actions for Ubuntu 22.04 Mar 3, 2023
directionless
directionless previously approved these changes Mar 3, 2023
Copy link
Contributor

@directionless directionless left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems okay. Though the labels imply there's some refactoring that might help.

@RebeccaMahany RebeccaMahany changed the title Support notification actions for Ubuntu 22.04 Support notification actions for Ubuntu 22.04/Wayland Mar 3, 2023
seejdev
seejdev previously approved these changes Mar 3, 2023
Copy link
Contributor

@directionless directionless left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks solid. But please put ctx first

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants